Bug 1046125 (php-doctrine-annotations)

Summary:

Review Request: php-doctrine-annotations - PHP docblock annotations parser library

Product:

[Fedora] Fedora

Reporter:

Shawn Iwinski <shawn>

Component:

Package Review

Assignee:

Remi Collet <fedora>

Status:

CLOSED RAWHIDE

QA Contact:

Fedora Extras Quality Assurance <extras-qa>

Severity:

medium

Docs Contact:

Priority:

medium

Version:

rawhide

CC:

fedora, package-review

Target Milestone:

---

Flags:

fedora: fedora-review+
gwync: fedora-cvs+

Target Release:

---

Hardware:

All

OS:

Linux

Whiteboard:

Fixed In Version:

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2014-01-06 18:14:04 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Bug Depends On:

1046121, 1046124

Bug Blocks:

1047109

Attachments:

Description	Flags
phpci.log	none
review.txt	none

Description Shawn Iwinski 2013-12-23 18:34:39 UTC

Spec URL: https://raw.github.com/siwinski/rpms/58afbf34df09331c037ce42a9f83d089708ec0ac/php-doctrine-annotations.spec

SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-doctrine-annotations-1.1.2-1.20131220gita11349d.fc20.src.rpm

Description:
PHP docblock annotations parser library (extracted from Doctrine Common).


Fedora Account System Username: siwinski

Comment 1 Remi Collet 2014-01-03 07:47:57 UTC

Created attachment 844860 [details]
phpci.log

phpcompatinfo version 2.26.0.

Comment 2 Remi Collet 2014-01-03 07:48:26 UTC

Created attachment 844861 [details]
review.txt

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1046125

Comment 3 Remi Collet 2014-01-03 07:50:16 UTC

[!]: Dist tag is present (not strictly required in GL).
  Please use %{?dist}

[!]: Package does not generate any conflict.
  Conflicts:     php-pear(pear.doctrine-project.org/DoctrineCommon) < 2.4
  Both packages provides Doctrine\Common\Annotations
  As /usr/share/pear is before /usr/share/php this will break
  autoloader relying on include_path.
  Also explain this package is a split-off DoctrineCommon

[!] Dependencies
  Of course wait for dependencies before import

Comment 4 Shawn Iwinski 2014-01-03 19:29:59 UTC

- Conditional %{?dist}
- Added conflict w/ PEAR-based DoctrineCommon pkg (version < 2.4)

Diff: https://github.com/siwinski/rpms/commit/77ae1377a204278a60818da848ebdf230d3c180a



Spec URL: https://raw.github.com/siwinski/rpms/77ae1377a204278a60818da848ebdf230d3c180a/php-doctrine-annotations.spec

SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-doctrine-annotations-1.1.2-2.20131220gita11349d.fc20.src.rpm

Comment 5 Remi Collet 2014-01-04 06:54:35 UTC

Release:       2%{github_release}%{?dist}

I agree have the dot in the constant value is simpler as you will only have to comment the definition when not needed. So you should probably use %{?github_release} ;)

[x]: Dist tag is present (not strictly required in GL).

[x]: Package does not generate any conflict.


Blocker fixed.


=== APPROVED ===

Comment 6 Shawn Iwinski 2014-01-04 15:33:15 UTC

THANKS for the review!


New Package SCM Request
=======================
Package Name: php-doctrine-annotations
Short Description: PHP docblock annotations parser library
Owners: siwinski
Branches: f19 f20 el6
InitialCC:

Comment 7 Gwyn Ciesla 2014-01-06 13:20:19 UTC

Git done (by process-git-requests).