Spec URL: https://raw.github.com/siwinski/rpms/58afbf34df09331c037ce42a9f83d089708ec0ac/php-doctrine-annotations.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-doctrine-annotations-1.1.2-1.20131220gita11349d.fc20.src.rpm Description: PHP docblock annotations parser library (extracted from Doctrine Common). Fedora Account System Username: siwinski
Created attachment 844860 [details] phpci.log phpcompatinfo version 2.26.0.
Created attachment 844861 [details] review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1046125
[!]: Dist tag is present (not strictly required in GL). Please use %{?dist} [!]: Package does not generate any conflict. Conflicts: php-pear(pear.doctrine-project.org/DoctrineCommon) < 2.4 Both packages provides Doctrine\Common\Annotations As /usr/share/pear is before /usr/share/php this will break autoloader relying on include_path. Also explain this package is a split-off DoctrineCommon [!] Dependencies Of course wait for dependencies before import
- Conditional %{?dist} - Added conflict w/ PEAR-based DoctrineCommon pkg (version < 2.4) Diff: https://github.com/siwinski/rpms/commit/77ae1377a204278a60818da848ebdf230d3c180a Spec URL: https://raw.github.com/siwinski/rpms/77ae1377a204278a60818da848ebdf230d3c180a/php-doctrine-annotations.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-doctrine-annotations-1.1.2-2.20131220gita11349d.fc20.src.rpm
Release: 2%{github_release}%{?dist} I agree have the dot in the constant value is simpler as you will only have to comment the definition when not needed. So you should probably use %{?github_release} ;) [x]: Dist tag is present (not strictly required in GL). [x]: Package does not generate any conflict. Blocker fixed. === APPROVED ===
THANKS for the review! New Package SCM Request ======================= Package Name: php-doctrine-annotations Short Description: PHP docblock annotations parser library Owners: siwinski Branches: f19 f20 el6 InitialCC:
Git done (by process-git-requests).