Bug 1047600
| Summary: | Review Request: php-phpseclib-crypt-aes - Pure-PHP implementation of AES | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson (Red Hat non-Fedora) <awilliam> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-01-14 19:49:01 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 1047596, 1047607 | ||||||||
| Bug Blocks: | 1047611 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Williamson (Red Hat non-Fedora)
2014-01-01 03:09:33 UTC
Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-aes/php-phpseclib-crypt-aes.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-aes/php-phpseclib-crypt-aes-0.3.5-2.fc21.src.rpm Created attachment 845783 [details]
phpci.log
phpcompatinfo version 2.26.0.
Created attachment 845784 [details]
review.txt
Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1047600
Issues:
=======
[!]: Requires correct, justified where necessary.
From package.xml, optional: php-mcrypt
Packager choice, but probably better for perf, and available.
[!]: Rpmlint is run on all rpms the build produces.
W: invalid-url URL: http://phpseclib.sourceforge.net/package/Crypt_AES HTTP Error 404: Not Found
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
As you have a link to the license file in package.xml you
can add this file to the package, which will avoid having
to block this review for missing License.
My though: this library stack is mostly a wrapper above mcrypt (probably used as some distro, like RHEL, don't have mcrypt), so It think it worth requiring it, as C implementation will be faster than pure PHP one.
The point of phpseclib is to be a pure PHP implementation of encryption for when non-PHP deps aren't available, so it seems wrong to depend on the optional non-PHP deps. But it's kind of a tough call. Again, *the license is in line in the source*, in all these packages. I'll fix all the URLs, no need to note on each review. [x]: Requires correct, justified where necessary.
=> ok, packager choice.
[x]: Rpmlint is run on all rpms the build produces.
=> URL fixed
New Package SCM Request ======================= Package Name: php-phpseclib-crypt-aes Short Description: Pure-PHP implementation of AES Owners: adamwill Branches: f20 el6 InitialCC: Git done (by process-git-requests). Building for Rawhide. http://koji.fedoraproject.org/koji/taskinfo?taskID=6405078 Package Change Request ====================== Package Name: php-phpseclib-net-ssh2 New Branches: f19 epel7 No owners specified. Package Change Request ====================== Package Name: php-phpseclib-crypt-aes New Branches: f19 epel7 Owners: adamwill Git done (by process-git-requests). |