Bug 1047607 - Review Request: php-phpseclib-crypt-rijndael - Pure-PHP implementation of Rijndael
Summary: Review Request: php-phpseclib-crypt-rijndael - Pure-PHP implementation of Rij...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1047596
Blocks: 1047600
TreeView+ depends on / blocked
 
Reported: 2014-01-01 03:22 UTC by Adam Williamson
Modified: 2015-05-04 19:24 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-11-04 08:00:15 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
phpci.log (7.49 KB, text/plain)
2014-01-05 16:06 UTC, Remi Collet
no flags Details
review.txt (7.88 KB, text/plain)
2014-01-05 16:07 UTC, Remi Collet
no flags Details

Description Adam Williamson 2014-01-01 03:22:59 UTC
Spec URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-Rijndael/php-phpseclib-Crypt-Rijndael.spec
SRPM URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-Rijndael/php-phpseclib-Crypt-Rijndael-0.3.5-1.fc21.src.rpm
Description: Does not use mcrypt, even when available, for reasons discussed in
Rijndael.php.
Fedora Account System Username: adamwill

Comment 2 Remi Collet 2014-01-05 16:06:18 UTC
Created attachment 845781 [details]
phpci.log

phpcompatinfo version 2.26.0.

Comment 3 Remi Collet 2014-01-05 16:07:00 UTC
Created attachment 845782 [details]
review.txt

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1047607

Comment 4 Remi Collet 2014-01-05 16:07:22 UTC
== Issues ==

[!]: Rpmlint is run on all rpms the build produces.
    W: invalid-url URL: http://phpseclib.sourceforge.net/package/Crypt_Rijndael HTTP Error 404: Not Found

[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.

     As you have a link to the license file in package.xml you
     can add this file to the package, which will avoid having
     to block this review for missing License.

Comment 5 Remi Collet 2014-01-07 08:35:28 UTC
[x]: Rpmlint is run on all rpms the build produces.

== APPROVED ==

Comment 6 Adam Williamson 2014-01-10 20:05:40 UTC
New Package SCM Request
=======================
Package Name: php-phpseclib-crypt-rijndael
Short Description: Pure-PHP implementation of Rijndael
Owners: adamwill
Branches: f20 el6
InitialCC:

Comment 7 Gwyn Ciesla 2014-01-10 20:22:20 UTC
Git done (by process-git-requests).

Comment 8 Adam Williamson 2014-01-14 20:04:12 UTC
Building for Rawhide - http://koji.fedoraproject.org/koji/taskinfo?taskID=6405147

Comment 9 Adam Williamson 2014-02-24 03:26:09 UTC
Package Change Request
======================
Package Name: php-phpseclib-net-rijndael
New Branches: f19 epel7

Comment 10 Gwyn Ciesla 2014-02-24 13:27:08 UTC
Not in pkgdb, no owners.

Comment 11 Adam Williamson 2014-02-25 18:25:50 UTC
Package Change Request
======================
Package Name: php-phpseclib-net-rijndael
New Branches: f19 epel7
Owners: adamwill

Comment 12 Gwyn Ciesla 2014-02-25 18:49:40 UTC
WARNING: Package does not appear to exist in pkgdb currently.

Comment 13 DO NOT USE account not monitored (old adamwill) 2014-11-02 01:29:18 UTC
Package Change Request
======================
Package Name: php-phpseclib-crypt-rijndael
New Branches: f19 epel7
Owners: adamwill

Comment 14 Gwyn Ciesla 2014-11-03 13:19:31 UTC
Git done (by process-git-requests).

Comment 15 Adam Williamson 2014-11-03 20:23:32 UTC
How long does it take to sync? I don't see it yet...

Comment 16 Adam Williamson 2014-11-04 02:31:07 UTC
https://admin.fedoraproject.org/pkgdb/package/php-phpseclib-crypt-rijndael/ also shows no EPEL 7 or F19 branch. Can you double check this, please? Thanks!

Comment 17 Remi Collet 2014-11-04 08:00:15 UTC
No need to keep the review "open", the package is in the repo for a while.

Resetting cvs tag for check by releng.

Comment 18 Gwyn Ciesla 2014-11-04 12:54:17 UTC
We're investigating, it's due to this: https://fedorahosted.org/rel-eng/ticket/6028

Comment 19 Gwyn Ciesla 2014-11-05 12:00:19 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.