Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-AES/php-phpseclib-Crypt-AES.spec SRPM URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-AES/php-phpseclib-Crypt-AES-0.3.5-1.fc21.src.rpm Description: Uses mcrypt, if available, and an internal implementation, otherwise. Fedora Account System Username: adamwill
Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-aes/php-phpseclib-crypt-aes.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-aes/php-phpseclib-crypt-aes-0.3.5-2.fc21.src.rpm
Created attachment 845783 [details] phpci.log phpcompatinfo version 2.26.0.
Created attachment 845784 [details] review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1047600
Issues: ======= [!]: Requires correct, justified where necessary. From package.xml, optional: php-mcrypt Packager choice, but probably better for perf, and available. [!]: Rpmlint is run on all rpms the build produces. W: invalid-url URL: http://phpseclib.sourceforge.net/package/Crypt_AES HTTP Error 404: Not Found [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. As you have a link to the license file in package.xml you can add this file to the package, which will avoid having to block this review for missing License. My though: this library stack is mostly a wrapper above mcrypt (probably used as some distro, like RHEL, don't have mcrypt), so It think it worth requiring it, as C implementation will be faster than pure PHP one.
The point of phpseclib is to be a pure PHP implementation of encryption for when non-PHP deps aren't available, so it seems wrong to depend on the optional non-PHP deps. But it's kind of a tough call. Again, *the license is in line in the source*, in all these packages. I'll fix all the URLs, no need to note on each review.
[x]: Requires correct, justified where necessary. => ok, packager choice. [x]: Rpmlint is run on all rpms the build produces. => URL fixed
New Package SCM Request ======================= Package Name: php-phpseclib-crypt-aes Short Description: Pure-PHP implementation of AES Owners: adamwill Branches: f20 el6 InitialCC:
Git done (by process-git-requests).
Building for Rawhide. http://koji.fedoraproject.org/koji/taskinfo?taskID=6405078
Package Change Request ====================== Package Name: php-phpseclib-net-ssh2 New Branches: f19 epel7
No owners specified.
Package Change Request ====================== Package Name: php-phpseclib-crypt-aes New Branches: f19 epel7 Owners: adamwill