Bug 1047608
| Summary: | Review Request: php-phpseclib-crypt-rsa - Pure-PHP PKCS#1 (v2.1) compliant implementation of RSA | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> | ||||||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||
| Severity: | medium | Docs Contact: | |||||||||||
| Priority: | medium | ||||||||||||
| Version: | rawhide | CC: | fedora, package-review, shawn | ||||||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2014-01-26 01:46:52 UTC | Type: | --- | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Bug Depends On: | 1047599, 1047603, 1047604 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Adam Williamson
2014-01-01 03:24:25 UTC
Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-rsa/php-phpseclib-crypt-rsa.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-rsa/php-phpseclib-crypt-rsa-0.3.5-2.fc21.src.rpm The openssl.cfg have obviously not the correct role (upstream bug)
Should be role="cfg", thus will be installed in /etc/pear
Notice: this is a bit ugly to manage in source code, as it is needed to check if run from sources tree or from install one.
Commonly used solution (ex taken from php-bartlett-PHP-CompatInfo)
In Crypt/RSA.php
$dir = '@cfg_dir@' . DIRECTORY_SEPARATOR . 'Crypt_RSA';
if (strpos($dir, '@') === false) {
// PEAR installer was used to install the package
} else {
// manual install
$dir = dirname(__FILE__)
}
$filename = $dir . DIRECTORY_SEPARATOR . 'openssl.cnf';
In package.xml
<file baseinstalldir="Crypt" name="RSA.php" role="php" >
<tasks:replace from="@cfg_dir@" to="cfg_dir" type="pear-config" />
</file>
<file name="openssl.cnf" role="cfg"/>
Created attachment 846562 [details]
Crypt_RSA-role.patch
Created attachment 846563 [details]
spec.patch
Upstream bug ref : https://sourceforge.net/p/phpseclib/bugs/4/ Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-rsa/php-phpseclib-crypt-rsa.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-rsa/php-phpseclib-crypt-rsa-0.3.5-3.fc21.src.rpm Created attachment 848057 [details]
phpci.log
Created attachment 848058 [details]
review.txt
Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1047608
[!] Package installs properly. Of course, wait for dependencies before importing the package. No Blocker == APPROVED == New Package SCM Request ======================= Package Name: php-phpseclib-Crypt-TripleDES Short Description: Pure-PHP implementation of Triple DES Owners: adamwill Branches: f20 el6 el7 InitialCC: WARNING: Invalid branch el7 requested: use epel7 WARNING: Requested package name php-phpseclib-Crypt-TripleDES doesn't match bug summary php-phpseclib-Crypt-RSA: fix. New Package SCM Request ======================= Package Name: php-phpseclib-crypt-rsa Short Description: Pure-PHP implementation of RSA Owners: adamwill Branches: f20 el6 epel7 InitialCC: Git done (by process-git-requests). Built for Rawhide. Package Change Request ====================== Package Name: php-phpseclib-crypt-rsa New Branches: f19 No owners specified. Package Change Request ====================== Package Name: php-phpseclib-crypt-rsa New Branches: f19 Owners: adamwill Git done (by process-git-requests). |