Spec URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-RSA/php-phpseclib-Crypt-RSA.spec SRPM URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-RSA/php-phpseclib-Crypt-RSA-0.3.5-1.fc21.src.rpm Description: Pure-PHP PKCS#1 (v2.1) compliant implementation of RSA. Fedora Account System Username: adamwill
Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-rsa/php-phpseclib-crypt-rsa.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-rsa/php-phpseclib-crypt-rsa-0.3.5-2.fc21.src.rpm
The openssl.cfg have obviously not the correct role (upstream bug) Should be role="cfg", thus will be installed in /etc/pear Notice: this is a bit ugly to manage in source code, as it is needed to check if run from sources tree or from install one. Commonly used solution (ex taken from php-bartlett-PHP-CompatInfo) In Crypt/RSA.php $dir = '@cfg_dir@' . DIRECTORY_SEPARATOR . 'Crypt_RSA'; if (strpos($dir, '@') === false) { // PEAR installer was used to install the package } else { // manual install $dir = dirname(__FILE__) } $filename = $dir . DIRECTORY_SEPARATOR . 'openssl.cnf'; In package.xml <file baseinstalldir="Crypt" name="RSA.php" role="php" > <tasks:replace from="@cfg_dir@" to="cfg_dir" type="pear-config" /> </file> <file name="openssl.cnf" role="cfg"/>
Created attachment 846562 [details] Crypt_RSA-role.patch
Created attachment 846563 [details] spec.patch
Upstream bug ref : https://sourceforge.net/p/phpseclib/bugs/4/
Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-rsa/php-phpseclib-crypt-rsa.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-rsa/php-phpseclib-crypt-rsa-0.3.5-3.fc21.src.rpm
Created attachment 848057 [details] phpci.log
Created attachment 848058 [details] review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1047608
[!] Package installs properly. Of course, wait for dependencies before importing the package. No Blocker == APPROVED ==
New Package SCM Request ======================= Package Name: php-phpseclib-Crypt-TripleDES Short Description: Pure-PHP implementation of Triple DES Owners: adamwill Branches: f20 el6 el7 InitialCC:
WARNING: Invalid branch el7 requested: use epel7 WARNING: Requested package name php-phpseclib-Crypt-TripleDES doesn't match bug summary php-phpseclib-Crypt-RSA: fix.
New Package SCM Request ======================= Package Name: php-phpseclib-crypt-rsa Short Description: Pure-PHP implementation of RSA Owners: adamwill Branches: f20 el6 epel7 InitialCC:
Git done (by process-git-requests).
Built for Rawhide.
Package Change Request ====================== Package Name: php-phpseclib-crypt-rsa New Branches: f19
No owners specified.
Package Change Request ====================== Package Name: php-phpseclib-crypt-rsa New Branches: f19 Owners: adamwill