Bug 1047603 - Review Request: php-phpseclib-crypt-hash - Pure-PHP implementations of keyed-hash message authentication codes (HMACs) and various cryptographic hashing functions
Summary: Review Request: php-phpseclib-crypt-hash - Pure-PHP implementations of keyed-...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1047596
Blocks: 1047608 1047611
TreeView+ depends on / blocked
 
Reported: 2014-01-01 03:16 UTC by Adam Williamson
Modified: 2014-02-25 18:48 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-01-14 19:55:19 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
phpci.log (8.14 KB, text/plain)
2014-01-07 09:02 UTC, Remi Collet
no flags Details
review.txt (7.86 KB, text/plain)
2014-01-07 09:02 UTC, Remi Collet
no flags Details

Description Adam Williamson 2014-01-01 03:16:02 UTC
Spec URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-Hash/php-phpseclib-Crypt-Hash.spec
SRPM URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-Hash/php-phpseclib-Crypt-Hash-0.3.5-1.fc21.src.rpm
Description: Uses hash() or mhash() if available and an internal implementation,
otherwise.  Currently supports the following: md2, md5, md5-96, sha1,
sha1-96, sha256, sha384, and sha512.
Fedora Account System Username: adamwill

Comment 2 Remi Collet 2014-01-07 09:02:00 UTC
Created attachment 846517 [details]
phpci.log

phpcompatinfo version 2.26.0.

Comment 3 Remi Collet 2014-01-07 09:02:36 UTC
Created attachment 846518 [details]
review.txt

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1047603

Comment 4 Remi Collet 2014-01-07 09:03:06 UTC
[x]: Requires correct, justified where necessary.
  optional, so packager choice
  php-hash
  php-mhash (emulated by hash in recent php, not available in EL-6)
  php-pear(phpseclib.sourceforge.net/Math_BigInteger) >= 0.3.0

Math_BigInteger seems mandatory for sha512 when hash/mhash not available
but hash is always available (currently in php-common).
I think it's still usefull to explicit requires one.

[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
  License text included in the single source file.

Comment 5 Adam Williamson 2014-01-10 20:03:10 UTC
I'll add the math-biginteger depend on import.

New Package SCM Request
=======================
Package Name: php-phpseclib-crypt-hash
Short Description: Pure-PHP implementations of keyed-hash message authentication codes (HMACs) and various cryptographic hashing functions
Owners: adamwill
Branches: f20 el6
InitialCC:

Comment 6 Gwyn Ciesla 2014-01-10 20:17:26 UTC
Git done (by process-git-requests).

Comment 7 Adam Williamson 2014-01-14 19:55:19 UTC
Building for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6405114

Comment 8 Adam Williamson 2014-02-24 03:25:37 UTC
Package Change Request
======================
Package Name: php-phpseclib-crypt-hash
New Branches: f19 epel7

Comment 9 Gwyn Ciesla 2014-02-24 13:24:07 UTC
No owners specified.

Comment 10 Adam Williamson 2014-02-25 18:25:11 UTC
Package Change Request
======================
Package Name: php-phpseclib-crypt-hash
New Branches: f19 epel7
Owners: adamwill

Comment 11 Gwyn Ciesla 2014-02-25 18:48:35 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.