Bug 1050216

Summary:	Thread consuming qpid messages can die silently
Product:	Red Hat OpenStack	Reporter:	Russell Bryant <rbryant>
Component:	openstack-heat	Assignee:	Jeff Peeler <jpeeler>
Status:	CLOSED ERRATA	QA Contact:	Amit Ugol <augol>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	3.0	CC:	ajeain, dkranz, eglynn, hateya, ndipanov, sbaker, sclewis, sdake, shardy, sradvan, yeylon
Target Milestone:	z4	Keywords:	OtherQA, ZStream
Target Release:	3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-heat-2013.1.4-2.el6ost	Doc Type:	Bug Fix
Doc Text:	Cause: All potential errors were not explicitly handled in the QPID driver's consuming thread. Consequence: Unhandled errors encountered by the QPID driver's consuming thread could cause it to die silently, so that no further incoming messages are received by that agent. Fix: The consuming thread has been made more resilient to potential errors. Result: Errors are now logged and the message consumption logic is then retried.	Story Points:	---
Clone Of:	1050213	Environment:
Last Closed:	2014-01-30 19:51:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1050213, 1050217
Bug Blocks:	1050214, 1050215

Description Russell Bryant 2014-01-08 21:05:15 UTC

+++ This bug was initially created as a clone of Bug #1050213 +++

The code for receiving and processing qpid messages runs in its own greenthread.  Unfortunately, there is a code path that if it raises an exception, the greenthread will die silently, without any entry in the log file.

In particular, the code in question is:

https://git.openstack.org/cgit/openstack/nova/tree/nova/openstack/common/rpc/impl_qpid.py?h=stable/grizzly#n468

if self.session.next_receiver() raises an exception other than qpid's Empty or ConnectionError exceptions, the thread will die and no more messages will be received.

The fix is to backport the portion of the following change that applies to impl_qpid.  That includes the new decorator in excutils and the change to impl_qpid.py.

Comment 1 Russell Bryant 2014-01-08 21:12:56 UTC

The change that needs to be backported is: https://review.openstack.org/#/c/32235/13

I also attached a version of the backport for nova to bug 1050213

Comment 3 Jeff Peeler 2014-01-09 18:00:36 UTC

Heat actually already contains these changes as Oslo was updated in commit 00e71c3d7810e2f9e12f57c0a713d2b8939bb70f. (Part of the fix was previously updated in commit eca7fdae8c61cce8b9be8d7c4d95664ff2c02694.)

Comment 4 Lon Hohberger 2014-01-14 19:46:54 UTC

This is a bug against RHOS 3.0 Grizzly, not Havana.

Those commits are not in the RHOS 3.0 heat packages nor upstream stable/grizzly.

Comment 6 Amit Ugol 2014-01-27 15:19:26 UTC

Changes from https://review.openstack.org/#/c/32235/13 were integrated to:
...heat/openstack/common/excutils.py
...heat/openstack/common/rpc/impl_kombu.py
...heat/openstack/common/rpc/impl_qpid.py

os:     RHEL 6.5
puddle: OpenStack/Grizzly/2014-01-22.1

Comment 8 errata-xmlrpc 2014-01-30 19:51:07 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0110.html