Bug 1050215 – Thread consuming qpid messages can die silently

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1050215 - Thread consuming qpid messages can die silently

Summary:	Thread consuming qpid messages can die silently

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat OpenStack
Classification:	Red Hat
Component:	openstack-cinder (Show other bugs)
Sub Component:
Version:	3.0
Hardware:	Unspecified Unspecified

Priority	urgent Severity urgent
Target Milestone:	z4
Target Release:	3.0
Assigned To:	Eric Harney
QA Contact:	Yogev Rabl
Docs Contact:

URL:
Whiteboard:
Keywords:	ZStream

Duplicates:	1065428 (view as bug list)
Depends On:	1050213 1050216 1050217
Blocks:	1025025 1050214 1065428
	Show dependency tree / graph

Reported:	2014-01-08 16:04 EST by Russell Bryant
Modified:	2018-02-08 05:12 EST (History)
CC List:	9 users (show)

See Also:
Fixed In Version:	openstack-cinder-2013.1.4-6.el6ost
Doc Type:	Bug Fix
Doc Text:	Cause: Unhandled errors in the QPID consuming thread. Consequence: The thread was be silently killed, isolating the component from the rest of the system. Fix: The consuming thread has been made more resilient to errors by ensuring it doesn't die on an unhandled error. Result: The error is now logged and the consuming thread operates as expected.
Story Points:	---
Clone Of:	1050213
Clones:	1054246 (view as bug list)
Environment:
Last Closed:	2014-01-30 14:50:58 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Launchpad	1189711	None	None	None	Never
OpenStack gerrit	65715	None	None	None	Never
Red Hat Product Errata	RHBA-2014:0110	normal	SHIPPED_LIVE	Red Hat Enterprise Linux OpenStack Platform 3 bug fix advisory	2014-01-30 19:48:26 EST

Groups: None (edit)

Description Russell Bryant 2014-01-08 16:04:45 EST

+++ This bug was initially created as a clone of Bug #1050213 +++

The code for receiving and processing qpid messages runs in its own greenthread.  Unfortunately, there is a code path that if it raises an exception, the greenthread will die silently, without any entry in the log file.

In particular, the code in question is:

https://git.openstack.org/cgit/openstack/nova/tree/nova/openstack/common/rpc/impl_qpid.py?h=stable/grizzly#n468

if self.session.next_receiver() raises an exception other than qpid's Empty or ConnectionError exceptions, the thread will die and no more messages will be received.

The fix is to backport the portion of the following change that applies to impl_qpid.  That includes the new decorator in excutils and the change to impl_qpid.py.

Comment 1 Russell Bryant 2014-01-08 16:12:34 EST

The change that needs to be backported is: https://review.openstack.org/#/c/32235/13

I also attached a version of the backport for nova to bug 1050213

Comment 3 Eric Harney 2014-01-09 11:26:19 EST

Link to submission for Cinder master.

Comment 7 Yogev Rabl 2014-01-28 07:16:32 EST

verified on:
python-cinderclient-1.0.4-1.el6ost.noarch
python-cinder-2013.1.4-6.el6ost.noarch
openstack-cinder-2013.1.4-6.el6ost.noarch

Comment 9 errata-xmlrpc 2014-01-30 14:50:58 EST

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0110.html

Comment 10 Sean Cohen 2014-03-12 10:07:31 EDT

*** Bug 1065428 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.