Bug 1050217 - Thread consuming qpid messages can die silently
Summary: Thread consuming qpid messages can die silently
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-ceilometer
Version: 3.0
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: z4
: 3.0
Assignee: Eoghan Glynn
QA Contact: Kevin Whitney
URL:
Whiteboard:
Depends On: 1050213
Blocks: 1050214 1050215 1050216
TreeView+ depends on / blocked
 
Reported: 2014-01-08 21:05 UTC by Russell Bryant
Modified: 2019-09-09 13:11 UTC (History)
8 users (show)

Fixed In Version: openstack-ceilometer-2013.1.4-2.el6ost
Doc Type: Bug Fix
Doc Text:
Cause: All potential errors were not explicitly handled in the QPID driver's consuming thread. Consequence: Unhandled errors encountered by the QPID driver's consuming thread could cause it to die silently, so that no further incoming messages are received by that agent. Fix: The consuming thread has been made more resilient to potential errors. Result: Errors are now logged and the message consumption logic is then retried.
Clone Of: 1050213
Environment:
Last Closed: 2014-01-30 19:51:13 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1189711 0 None None None Never
OpenStack gerrit 67838 0 None None None Never
Red Hat Product Errata RHBA-2014:0110 0 normal SHIPPED_LIVE Red Hat Enterprise Linux OpenStack Platform 3 bug fix advisory 2014-01-31 00:48:26 UTC

Description Russell Bryant 2014-01-08 21:05:59 UTC
+++ This bug was initially created as a clone of Bug #1050213 +++

The code for receiving and processing qpid messages runs in its own greenthread.  Unfortunately, there is a code path that if it raises an exception, the greenthread will die silently, without any entry in the log file.

In particular, the code in question is:

https://git.openstack.org/cgit/openstack/nova/tree/nova/openstack/common/rpc/impl_qpid.py?h=stable/grizzly#n468

if self.session.next_receiver() raises an exception other than qpid's Empty or ConnectionError exceptions, the thread will die and no more messages will be received.

The fix is to backport the portion of the following change that applies to impl_qpid.  That includes the new decorator in excutils and the change to impl_qpid.py.

Comment 1 Russell Bryant 2014-01-08 21:13:14 UTC
The change that needs to be backported is: https://review.openstack.org/#/c/32235/13

I also attached a version of the backport for nova to bug 1050213

Comment 3 Eoghan Glynn 2014-01-20 14:22:18 UTC
Fix proposed upstream to stable/grizzly:

  https://review.openstack.org/67838

(for completeness only, without the expectation that it will land as that branch is restricted now to security fixes)

Comment 4 Eoghan Glynn 2014-01-20 14:24:49 UTC
Backport proposed to internal gerrit:

  https://code.engineering.redhat.com/gerrit/#/c/18581/

Comment 7 Kevin Whitney 2014-01-27 17:57:41 UTC
Verified:

1) retry decorator is in place

  /usr/lib/python2.6/site-packages/ceilometer/openstack/common/rpc/impl_qpid.py

2) Package
    Installed Packages
    Name        : python-ceilometer
    Arch        : noarch
    Version     : 2013.1.4
    Release     : 2.el6ost

Comment 9 errata-xmlrpc 2014-01-30 19:51:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0110.html


Note You need to log in before you can comment on or make changes to this bug.