Bug 1079603

Summary:	[regression] lab controller reboot command has no sleep
Product:	[Retired] Beaker	Reporter:	Bill Peck <bpeck>
Component:	lab controller	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	0.16	CC:	aigao, asaha, dcallagh, rmancy, xjia
Target Milestone:	0.16.1	Keywords:	Regression, Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-03-26 23:54:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1079816
Bug Blocks:

Description Bill Peck 2014-03-22 02:28:11 UTC

Description of problem:

The way the reboot command and quiescent period is implemented prevents beaker-provision from any delay at all when issuing a reboot command.

This isn't a problem for most systems since there will always be an off command before the reboot command.  but for the 1% of systems that are configured with "leave-on" they will get an off and on in very quick succession.

Version-Release number of selected component (if applicable):
0.16.0

How reproducible:
Everytime

Steps to Reproduce:
1. Configure a system with leave on
2. watch the system
3. issue a reboot

Actual results:
reboot will issue an off and on almost instantly

Expected results:
off
delay
on

Comment 2 Dan Callaghan 2014-03-23 23:19:29 UTC

This was just a problem with the database upgrades. It was missing a statement to set all existing rows to 5. You can run the UPDATE statement now to fix the problem.

http://git.beaker-project.org/cgit/beaker/commit/?h=release-0.16&id=0d8708a9eb5a469dd599b78467bd6245caf94839

Comment 3 Dan Callaghan 2014-03-23 23:43:54 UTC


*** This bug has been marked as a duplicate of bug 1078620 ***

Comment 4 Bill Peck 2014-03-24 01:48:24 UTC

Please look at the code again.  No matter what timeout value I give the system considers a reboot to be one command.  It executes an off and then immediately does an on.

Comment 5 Dan Callaghan 2014-03-24 03:06:31 UTC

Sorry, yes you're right. The quiescent period is not applied between off and on for a 'reboot' command.

I think the idea for the quiescent period was originally that the server would split 'reboot' into 'off' and 'on' so that the quiescent period is applied properly. However that did not happen.

Comment 6 Dan Callaghan 2014-03-24 04:06:47 UTC

On Gerrit: http://gerrit.beaker-project.org/2948

I also noticed that consecutive commands do not have the quiescent period calculated correctly: http://gerrit.beaker-project.org/2949

Comment 7 Dan Callaghan 2014-03-24 04:56:38 UTC

(In reply to Dan Callaghan from comment #6)
> I also noticed that consecutive commands do not have the quiescent period
> calculated correctly: http://gerrit.beaker-project.org/2949

I filed bug 1079816 for this.

Comment 13 Dan Callaghan 2014-03-26 23:54:28 UTC

Beaker 0.16.1 has been released.