Bug 1091648
| Summary: | Bad error checking code in feature/gfid-access | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Keith Schincke <kschinck> |
| Component: | core | Assignee: | Ric Wheeler <rwheeler> |
| Status: | CLOSED NOTABUG | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.5.0 | CC: | asriram, gluster-bugs, mhideo, nlevinki, rhs-bugs, rwheeler, storage-doc |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-19 14:52:49 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This issue was fixed with the following unrelated commit http://git.gluster.org/?p=glusterfs.git;a=commitdiff;h=99781d55f16373e793138c7b011eea09a62075b9 bz: https://bugzilla.redhat.com/show_bug.cgi?id=1104919 |
Description of problem: On line 99 gfid-access.c there is a check to see if the length of the blob is compaired to blob_len_len. This test is repeated on line 100. This resutls in a len = strnlen (blob, blob_len); if (len == blob_len) if (len == blob_len) { gf_log (this->name, GF_LOG_ERROR, "gfid: %s. No null byte present.", args->gfid); goto err; } Version-Release number of selected component (if applicable): In at least 3.5 and glusterfs-20140408.5216e53 The code was merged here: https://github.com/gluster/glusterfs/commit/3b8b184afe5579425e0e4dcb50dd8dd99d33b63a How reproducible: Always. Steps to Reproduce: 1. Look at line 99 of xlators/features/gfid-access/src/gfid-access.c 2. 3. Actual results: Expected results: Additional info: Delete either line 99 or 100.