Bug 1091704
| Summary: | qupzilla bundles qtsingleapplication (and qtlockedfile) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | ||||||||
| Component: | qupzilla | Assignee: | Raphael Groner <projects.rg> | ||||||||
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | rawhide | CC: | christoph.wickert, gregor, kevin, projects.rg, rdieter, tomspur, volker27 | ||||||||
| Target Milestone: | --- | Keywords: | FutureFeature, Reopened | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| URL: | https://github.com/QupZilla/qupzilla/issues/1503 | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | qtsingleapplication-2.6.1-23.fc22 | Doc Type: | Enhancement | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2015-08-07 13:02:54 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 1206841, 1209260 | ||||||||||
| Bug Blocks: | 504493 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Ville Skyttä
2014-04-27 12:55:12 UTC
Created attachment 890223 [details]
Sources patch
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle. Changing version to '22'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22 What's the state here? I may help as co-maintainer. Unbundling is not possible currently at least for a Qt5 build, until qtsingleapplication will be availabe also for Qt5, see bug #1206841. Same qt5 issue for qtlockedfile that BR: qt4-devel explicitly. qtsingleapplication and qtlockedfile are both fixed to build with qt5, see depending bugs. Let's wait till the patches are applied properly in PkgDB. Not possible to unbundle qtsingleapplication because upstream added some additional functionality directly into the source. For instance, there's no setAppId method in unbundled qtsingleapplication.h file that is called from qupzilla code. https://github.com/QupZilla/qupzilla/issues/1503 Please leave this bug open until it is fully resolved. See the 'must' in this guideline section: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#When_a_Bundled_Library_is_Discovered_Post-Review Created attachment 1054023 [details]
specfile patch to unbundle qtsingleapplication
Please apply this patch.
I've patched qtsingleapplication to provide the two new API functions as differences between qtsingleapplication upstream and qupzilla's embedded fork.
Rex, we may provide an update in combination with the new qtsingleapplication-qt5. Could you do that? qtsingleapplication-2.6.1-21.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/qtsingleapplication-2.6.1-21.fc22 qtsingleapplication-2.6.1-21.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/qtsingleapplication-2.6.1-21.fc21 There's a typo in the patch. Needs to be CONFIG+=QtSingleApplication (without spaces). qupzilla-1.8.6-6.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/qupzilla-1.8.6-6.fc22 qupzilla-1.8.6-6.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/qupzilla-1.8.6-6.fc21 qtsingleapplication-2.6.1-23.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/qtsingleapplication-2.6.1-23.fc22 qtsingleapplication-2.6.1-23.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/qtsingleapplication-2.6.1-23.fc21 Package qupzilla-1.8.6-6.fc21, qtsingleapplication-2.6.1-21.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing qupzilla-1.8.6-6.fc21 qtsingleapplication-2.6.1-21.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-11952/qtsingleapplication-2.6.1-21.fc21,qupzilla-1.8.6-6.fc21 then log in and leave karma (feedback). qupzilla-1.8.6-6.fc21, qtsingleapplication-2.6.1-21.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. qtsingleapplication-2.6.1-21.fc22, qupzilla-1.8.6-6.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. qtsingleapplication-2.6.1-23.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. qtsingleapplication-2.6.1-23.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. Falkon 3.1.0 now uses a fork that uses D-Bus instead of a lock file, which avoids bug #1551678. |