Bug 1091704

Summary: qupzilla bundles qtsingleapplication (and qtlockedfile)
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: qupzillaAssignee: Raphael Groner <projects.rg>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: high    
Version: rawhideCC: cwickert, gregor, kevin, projects.rg, rdieter, tomspur, volker27
Target Milestone: ---Keywords: FutureFeature, Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/QupZilla/qupzilla/issues/1503
See Also: https://bugzilla.redhat.com/show_bug.cgi?id=1209261
Whiteboard:
Fixed In Version: qtsingleapplication-2.6.1-23.fc22 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-07 09:02:54 EDT Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 1206841, 1209260    
Bug Blocks: 504493    
Attachments:
Description Flags
Specfile patch
none
Sources patch
none
specfile patch to unbundle qtsingleapplication none

Description Ville Skyttä 2014-04-27 08:55:12 EDT
Created attachment 890222 [details]
Specfile patch

https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
https://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries

qupzilla is using a bundled version of qtsingleapplication (and its dependency, qtlockedfile). The bundled version is somewhat different than the system one and isn't switchable without code changes, but attached is two patches that constitute a start.
Comment 1 Ville Skyttä 2014-04-27 08:55:59 EDT
Created attachment 890223 [details]
Sources patch
Comment 2 Jaroslav Reznik 2015-03-03 10:44:37 EST
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22
Comment 3 Raphael Groner 2015-03-31 08:43:48 EDT
What's the state here? I may help as co-maintainer.
Comment 4 Raphael Groner 2015-04-06 16:46:01 EDT
Unbundling is not possible currently at least for a Qt5 build, until qtsingleapplication will be availabe also for Qt5, see bug #1206841.
Comment 5 Raphael Groner 2015-04-06 16:48:04 EDT
Same qt5 issue for qtlockedfile that BR: qt4-devel explicitly.
Comment 6 Raphael Groner 2015-04-26 07:35:07 EDT
qtsingleapplication and qtlockedfile are both fixed to build with qt5, see depending bugs. Let's wait till the patches are applied properly in PkgDB.
Comment 7 Raphael Groner 2015-05-21 13:12:26 EDT
Not possible to unbundle qtsingleapplication because upstream added some additional functionality directly into the source.
For instance, there's no setAppId method in unbundled qtsingleapplication.h file that is called from qupzilla code.
https://github.com/QupZilla/qupzilla/issues/1503
Comment 8 Thomas Spura 2015-05-21 13:59:13 EDT
Please leave this bug open until it is fully resolved. See the 'must' in this guideline section:
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#When_a_Bundled_Library_is_Discovered_Post-Review
Comment 9 Raphael Groner 2015-07-20 16:09:27 EDT
Created attachment 1054023 [details]
specfile patch to unbundle qtsingleapplication

Please apply this patch.

I've patched qtsingleapplication to provide the two new API functions as differences between qtsingleapplication upstream and qupzilla's embedded fork.
Comment 10 Raphael Groner 2015-07-20 16:12:00 EDT
Rex, we may provide an update in combination with the new qtsingleapplication-qt5. Could you do that?
Comment 11 Fedora Update System 2015-07-20 16:25:43 EDT
qtsingleapplication-2.6.1-21.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/qtsingleapplication-2.6.1-21.fc22
Comment 12 Fedora Update System 2015-07-20 16:39:24 EDT
qtsingleapplication-2.6.1-21.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/qtsingleapplication-2.6.1-21.fc21
Comment 13 Raphael Groner 2015-07-22 02:54:08 EDT
There's a typo in the patch. Needs to be CONFIG+=QtSingleApplication (without spaces).
Comment 14 Fedora Update System 2015-07-22 15:15:08 EDT
qupzilla-1.8.6-6.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/qupzilla-1.8.6-6.fc22
Comment 15 Fedora Update System 2015-07-22 15:44:59 EDT
qupzilla-1.8.6-6.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/qupzilla-1.8.6-6.fc21
Comment 16 Fedora Update System 2015-07-24 17:23:53 EDT
qtsingleapplication-2.6.1-23.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/qtsingleapplication-2.6.1-23.fc22
Comment 17 Fedora Update System 2015-07-24 17:41:30 EDT
qtsingleapplication-2.6.1-23.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/qtsingleapplication-2.6.1-23.fc21
Comment 18 Fedora Update System 2015-07-28 21:36:08 EDT
Package qupzilla-1.8.6-6.fc21, qtsingleapplication-2.6.1-21.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing qupzilla-1.8.6-6.fc21 qtsingleapplication-2.6.1-21.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-11952/qtsingleapplication-2.6.1-21.fc21,qupzilla-1.8.6-6.fc21
then log in and leave karma (feedback).
Comment 19 Fedora Update System 2015-08-07 09:02:54 EDT
qupzilla-1.8.6-6.fc21, qtsingleapplication-2.6.1-21.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 20 Fedora Update System 2015-08-07 09:09:10 EDT
qtsingleapplication-2.6.1-21.fc22, qupzilla-1.8.6-6.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 21 Fedora Update System 2015-08-10 05:56:02 EDT
qtsingleapplication-2.6.1-23.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 22 Fedora Update System 2015-08-10 05:57:26 EDT
qtsingleapplication-2.6.1-23.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.