Bug 1100461

Summary: Review Request: rubygem-minitest-stub-const - Stub constants for the duration of a block in MiniTest
Product: [Fedora] Fedora Reporter: Vít Ondruch <vondruch>
Component: Package ReviewAssignee: Josef Stribny <jstribny>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: hhorak, jstribny, package-review, tdawson
Target Milestone: ---Flags: jstribny: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rubygem-minitest-stub-const-0.1-1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-05-28 08:08:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1100768    

Description Vít Ondruch 2014-05-22 20:43:26 UTC
Spec URL: http://people.redhat.com/vondruch/rubygem-minitest-stub-const.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-minitest-stub-const-0.1-1.fc21.src.rpm
Description: Stub constants for the duration of a block in MiniTest.
Like RSpec's stub_const, but boring and non-magical.
Fedora Account System Username: vondruch



I requested inclusion of license file here:
https://github.com/adammck/minitest-stub-const/issues/1

Comment 1 Josef Stribny 2014-05-23 08:36:47 UTC
It builds && works, the spec is according to guidelines, tests are run and rpmlint doesn't complain => APPROVING.

Please update to the latest release which contains LICENSE and README (your PR) before pushing.

Comment 2 Vít Ondruch 2014-05-23 08:41:43 UTC
Thanks for the review!




New Package SCM Request
=======================
Package Name: rubygem-minitest-stub-const
Short Description: Stub constants for the duration of a block in MiniTest
Upstream URL: https://github.com/adammck/minitest-stub-const
Owners: vondruch
Branches:
InitialCC:

Comment 3 Gwyn Ciesla 2014-05-27 13:15:31 UTC
Git done (by process-git-requests).

Comment 4 Gwyn Ciesla 2014-05-27 13:23:18 UTC
Git done (by process-git-requests).

Comment 5 Troy Dawson 2014-12-18 23:40:30 UTC
Package Change Request
======================
Package Name: rubygem-minitest-stub-const
New Branches: epel7
Owners: tdawson

Comment 6 Gwyn Ciesla 2014-12-19 13:37:34 UTC
Git done (by process-git-requests).