Bug 1100461 - Review Request: rubygem-minitest-stub-const - Stub constants for the duration of a block in MiniTest
Summary: Review Request: rubygem-minitest-stub-const - Stub constants for the duration...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Josef Stribny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1100768
TreeView+ depends on / blocked
 
Reported: 2014-05-22 20:43 UTC by Vít Ondruch
Modified: 2016-01-04 05:52 UTC (History)
4 users (show)

Fixed In Version: rubygem-minitest-stub-const-0.1-1.fc21
Clone Of:
Environment:
Last Closed: 2014-05-28 08:08:29 UTC
Type: ---
Embargoed:
jstribny: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Vít Ondruch 2014-05-22 20:43:26 UTC 
Spec URL: http://people.redhat.com/vondruch/rubygem-minitest-stub-const.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-minitest-stub-const-0.1-1.fc21.src.rpm
Description: Stub constants for the duration of a block in MiniTest.
Like RSpec's stub_const, but boring and non-magical.
Fedora Account System Username: vondruch



I requested inclusion of license file here:
https://github.com/adammck/minitest-stub-const/issues/1
Comment 1 Josef Stribny 2014-05-23 08:36:47 UTC 
It builds && works, the spec is according to guidelines, tests are run and rpmlint doesn't complain => APPROVING.

Please update to the latest release which contains LICENSE and README (your PR) before pushing.
Comment 2 Vít Ondruch 2014-05-23 08:41:43 UTC 
Thanks for the review!




New Package SCM Request
=======================
Package Name: rubygem-minitest-stub-const
Short Description: Stub constants for the duration of a block in MiniTest
Upstream URL: https://github.com/adammck/minitest-stub-const
Owners: vondruch
Branches:
InitialCC:
Comment 3 Gwyn Ciesla 2014-05-27 13:15:31 UTC 
Git done (by process-git-requests).
Comment 4 Gwyn Ciesla 2014-05-27 13:23:18 UTC 
Git done (by process-git-requests).
Comment 5 Troy Dawson 2014-12-18 23:40:30 UTC 
Package Change Request
======================
Package Name: rubygem-minitest-stub-const
New Branches: epel7
Owners: tdawson
Comment 6 Gwyn Ciesla 2014-12-19 13:37:34 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.