Bug 1101554

Summary:	[RFE] HE-ha: use vdsm api instead of vdsClient
Product:	[oVirt] ovirt-hosted-engine-ha	Reporter:	Yedidyah Bar David <didi>
Component:	RFEs	Assignee:	Simone Tiraboschi <stirabos>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Artyom <alukiano>
Severity:	medium	Docs Contact:
Priority:	high
Version:	---	CC:	alukiano, bugs, c.handel, dfediuck, gklein, istein, mavital, melewis, mgoldboi, mkalinin, msivak, sbonazzo, s.danzi, sherold, stirabos, ylavi
Target Milestone:	ovirt-4.1.1	Keywords:	FutureFeature, Reopened, Triaged
Target Release:	2.1.0.3	Flags:	rule-engine: ovirt-4.1+ sherold: Triaged+ alukiano: testing_plan_complete- mgoldboi: planning_ack+ sbonazzo: devel_ack+ mavital: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	With this update, the code interfacing with VDSM now uses the VDSM API directly instead of using vdsClient and xmlrpc.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-21 09:51:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1005923, 1372237

Description Yedidyah Bar David 2014-05-27 13:58:15 UTC

Our python code interfacing with vdsm should use its api and not run vdsClient. This will allow in principle simpler code (no need to parse output), faster execution (do not run an external program) etc.

vdsClient was used up until now because it was somewhat simpler to debug and because in the past there were some issues using the api in certain cases.

I am currently opening this bug due to an expected breakage caused by future fixing of bug #1005923 . This breakage can (obviously) be solved in other ways (including asking vdsm to add an option '--force' or something like that), but it seems that moving to use only the api is the better approach in the long run.

Comment 1 Sandro Bonazzola 2014-06-10 12:14:45 UTC

Setup side is on Bug #1101553

Comment 2 Sandro Bonazzola 2016-02-18 08:12:47 UTC

Martin isn't this already addressed in 3.6?

Comment 3 Simone Tiraboschi 2016-02-18 09:01:09 UTC

ovirt-hosted-engine-setup always uses vdscli.
ovirt-ha-broker probably still uses vdsClient somewhere for the monitoring.

Comment 4 Simone Tiraboschi 2016-09-14 14:06:27 UTC

*** Bug 1343112 has been marked as a duplicate of this bug. ***

Comment 5 Yaniv Lavi 2017-01-08 15:27:56 UTC

Should this be on QA?

Comment 6 Artyom 2017-01-25 15:17:46 UTC

Verified on ovirt-hosted-engine-ha-2.1.0-1.el7ev.noarch

1) Ran HE CLI commands (vm-start, vm-poweroff, add-console-password...)
2) Checked VDSM log(no lines with xmlrpc header)

Comment 7 Simone Tiraboschi 2017-02-14 13:52:02 UTC

A createVolume call was still using xml-rpc.

Comment 8 Red Hat Bugzilla Rules Engine 2017-02-14 13:52:23 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 9 Artyom 2017-02-20 14:49:34 UTC

Verified on ovirt-hosted-engine-ha-2.1.0.3-1.el7ev.noarch

Deploy on 3 storage types NFS, ISCSI, GlusterFS and check the VDSM log for the xmlrpc calls.