Bug 1101554 - [RFE] HE-ha: use vdsm api instead of vdsClient
Summary: [RFE] HE-ha: use vdsm api instead of vdsClient
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-hosted-engine-ha
Classification: oVirt
Component: RFEs
Version: ---
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-4.1.1
: 2.1.0.3
Assignee: Simone Tiraboschi
QA Contact: Artyom
URL:
Whiteboard:
: 1343112 (view as bug list)
Depends On:
Blocks: 1005923 1372237
TreeView+ depends on / blocked
 
Reported: 2014-05-27 13:58 UTC by Yedidyah Bar David
Modified: 2017-04-21 09:51 UTC (History)
16 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-04-21 09:51:55 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.1+
sherold: Triaged+
alukiano: testing_plan_complete-
mgoldboi: planning_ack+
sbonazzo: devel_ack+
mavital: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1101553 0 low CLOSED [HE-setup] Use vdsm api instead of vdsClient 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1364034 0 high CLOSED Hosted Engine always show "Not running" status in cockpit after deploy it. 2021-02-22 00:41:40 UTC
oVirt gerrit 62729 0 master MERGED jsonrpc: removing vdsClient 2016-10-12 10:12:17 UTC
oVirt gerrit 72068 0 master MERGED jsonrpc: avoid using vdscli 2017-02-15 12:51:21 UTC
oVirt gerrit 72300 0 v2.1.z MERGED jsonrpc: avoid using vdscli 2017-02-15 13:02:02 UTC

Internal Links: 1101553 1364034

Description Yedidyah Bar David 2014-05-27 13:58:15 UTC 
Our python code interfacing with vdsm should use its api and not run vdsClient. This will allow in principle simpler code (no need to parse output), faster execution (do not run an external program) etc.

vdsClient was used up until now because it was somewhat simpler to debug and because in the past there were some issues using the api in certain cases.

I am currently opening this bug due to an expected breakage caused by future fixing of bug #1005923 . This breakage can (obviously) be solved in other ways (including asking vdsm to add an option '--force' or something like that), but it seems that moving to use only the api is the better approach in the long run.
Comment 1 Sandro Bonazzola 2014-06-10 12:14:45 UTC 
Setup side is on Bug #1101553
Comment 2 Sandro Bonazzola 2016-02-18 08:12:47 UTC 
Martin isn't this already addressed in 3.6?
Comment 3 Simone Tiraboschi 2016-02-18 09:01:09 UTC 
ovirt-hosted-engine-setup always uses vdscli.
ovirt-ha-broker probably still uses vdsClient somewhere for the monitoring.
Comment 4 Simone Tiraboschi 2016-09-14 14:06:27 UTC 
*** Bug 1343112 has been marked as a duplicate of this bug. ***
Comment 5 Yaniv Lavi 2017-01-08 15:27:56 UTC 
Should this be on QA?
Comment 6 Artyom 2017-01-25 15:17:46 UTC 
Verified on ovirt-hosted-engine-ha-2.1.0-1.el7ev.noarch

1) Ran HE CLI commands (vm-start, vm-poweroff, add-console-password...)
2) Checked VDSM log(no lines with xmlrpc header)
Comment 7 Simone Tiraboschi 2017-02-14 13:52:02 UTC 
A createVolume call was still using xml-rpc.
Comment 8 Red Hat Bugzilla Rules Engine 2017-02-14 13:52:23 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 9 Artyom 2017-02-20 14:49:34 UTC 
Verified on ovirt-hosted-engine-ha-2.1.0.3-1.el7ev.noarch

Deploy on 3 storage types NFS, ISCSI, GlusterFS and check the VDSM log for the xmlrpc calls.
Note You need to log in before you can comment on or make changes to this bug.