Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
First Last Prev Next    This bug is not in your last search results.
Bug 1101554 - [RFE] HE-ha: use vdsm api instead of vdsClient
[RFE] HE-ha: use vdsm api instead of vdsClient
Status: CLOSED CURRENTRELEASE
Product: ovirt-hosted-engine-ha
Classification: oVirt
Component: RFEs (Show other bugs)
---
Unspecified Unspecified
high Severity medium (vote)
: ovirt-4.1.1
: 2.1.0.3
Assigned To: Simone Tiraboschi
Artyom
: FutureFeature, Reopened, Triaged
: 1343112 (view as bug list)
Depends On:
Blocks: 1005923 1372237
  Show dependency tree / graph
 
Reported: 2014-05-27 09:58 EDT by Yedidyah Bar David
Modified: 2017-04-21 05:51 EDT (History)
16 users (show)

See Also:
Fixed In Version:
Doc Type: Enhancement
Doc Text:
With this update, the code interfacing with VDSM now uses the VDSM API directly instead of using vdsClient and xmlrpc.
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-04-21 05:51:55 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: Integration
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rule-engine: ovirt‑4.1+
sherold: Triaged+
alukiano: testing_plan_complete-
mgoldboi: planning_ack+
sbonazzo: devel_ack+
mavital: testing_ack+

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


External Trackers
Tracker ID Priority Status Summary Last Updated
oVirt gerrit 62729 master MERGED jsonrpc: removing vdsClient 2016-10-12 06:12 EDT
oVirt gerrit 72068 master MERGED jsonrpc: avoid using vdscli 2017-02-15 07:51 EST
oVirt gerrit 72300 v2.1.z MERGED jsonrpc: avoid using vdscli 2017-02-15 08:02 EST

  None (edit)
Description Yedidyah Bar David 2014-05-27 09:58:15 EDT 
Our python code interfacing with vdsm should use its api and not run vdsClient. This will allow in principle simpler code (no need to parse output), faster execution (do not run an external program) etc.

vdsClient was used up until now because it was somewhat simpler to debug and because in the past there were some issues using the api in certain cases.

I am currently opening this bug due to an expected breakage caused by future fixing of bug #1005923 . This breakage can (obviously) be solved in other ways (including asking vdsm to add an option '--force' or something like that), but it seems that moving to use only the api is the better approach in the long run.
Comment 1 Sandro Bonazzola 2014-06-10 08:14:45 EDT 
Setup side is on Bug #1101553
Comment 2 Sandro Bonazzola 2016-02-18 03:12:47 EST 
Martin isn't this already addressed in 3.6?
Comment 3 Simone Tiraboschi 2016-02-18 04:01:09 EST 
ovirt-hosted-engine-setup always uses vdscli.
ovirt-ha-broker probably still uses vdsClient somewhere for the monitoring.
Comment 4 Simone Tiraboschi 2016-09-14 10:06:27 EDT 
*** Bug 1343112 has been marked as a duplicate of this bug. ***
Comment 5 Yaniv Lavi 2017-01-08 10:27:56 EST 
Should this be on QA?
Comment 6 Artyom 2017-01-25 10:17:46 EST 
Verified on ovirt-hosted-engine-ha-2.1.0-1.el7ev.noarch

1) Ran HE CLI commands (vm-start, vm-poweroff, add-console-password...)
2) Checked VDSM log(no lines with xmlrpc header)
Comment 7 Simone Tiraboschi 2017-02-14 08:52:02 EST 
A createVolume call was still using xml-rpc.
Comment 8 Red Hat Bugzilla Rules Engine 2017-02-14 08:52:23 EST 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 9 Artyom 2017-02-20 09:49:34 EST 
Verified on ovirt-hosted-engine-ha-2.1.0.3-1.el7ev.noarch

Deploy on 3 storage types NFS, ISCSI, GlusterFS and check the VDSM log for the xmlrpc calls.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.