Bug 1105175
| Summary: | -1 should not be used to represent "unlimited" for activation keys and host collections | ||
|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Sachin Ghai <sghai> |
| Component: | WebUI | Assignee: | Walden Raines <walden> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | sthirugn <sthirugn> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 6.0.3 | CC: | bkearney, jmontleo, sthirugn, tomckay, walden |
| Target Milestone: | Unspecified | ||
| Target Release: | Unused | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://projects.theforeman.org/issues/6078 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-09-11 12:23:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sachin Ghai
2014-06-05 13:56:31 UTC
Since this issue was entered in Red Hat Bugzilla, the release flag has been set to ? to ensure that it is properly evaluated for this release. The internal value of "unlimited" is in fact -1 so this is behaving correctly. The fix is likely to make the UI widget better at preventing values outside of positive integer range plus zero. This BZ can remain open but I'm moving it to low priority and severity as everything functions correctly. This may be a duplicate of other BZs having to do with UI widget text field validations. (In reply to Tom McKay from comment #3) > This BZ can remain open but I'm moving it to low priority and severity as > everything functions correctly. I would disagree with that. Our users should not be forced to know that our internal value of "unlimited" is -1. Using -1 to represent "unlimited" is a poor design to start with and, as far as the user is concerned, -1 should be an invalid value. From the user's perspective, the checkbox is the only thing that determines whether or not the system group is "unlimited", not some arbitrary and poorly chosen convention. Created redmine issue http://projects.theforeman.org/issues/6127 from this bug Changing summary this to reflect system-wide nature of problem. For both activation keys and host collections we should not use -1 to represent "unlimited". This issue captures the following work: * Fix the client side UI so that only > 1 limits can be sent * Fix the server side so that "unlimited" is represented as a boolean and that limit is ignored if true * Check that candlepin integration still works *** Bug 1110482 has been marked as a duplicate of this bug. *** Moving to POST since upstream bug http://projects.theforeman.org/issues/6514 has been closed ------------- Walden Raines This is fixed with https://github.com/Katello/katello/pull/4360 ------------- Walden Raines Applied in changeset commit:katello|607f4e7fdeefa10091b24a8a06fd2a45939c6038. Verified. Version Tested: GA Snap 7 - Satellite-6.0.4-RHEL-6-20140829.0 * apr-util-ldap-1.3.9-3.el6_0.1.x86_64 * candlepin-0.9.23-1.el6_5.noarch * candlepin-common-1.0.1-1.el6_5.noarch * candlepin-scl-1-5.el6_4.noarch * candlepin-scl-quartz-2.1.5-5.el6_4.noarch * candlepin-scl-rhino-1.7R3-1.el6_4.noarch * candlepin-scl-runtime-1-5.el6_4.noarch * candlepin-selinux-0.9.23-1.el6_5.noarch * candlepin-tomcat6-0.9.23-1.el6_5.noarch * elasticsearch-0.90.10-6.el6sat.noarch * foreman-1.6.0.42-1.el6sat.noarch * foreman-compute-1.6.0.42-1.el6sat.noarch * foreman-gce-1.6.0.42-1.el6sat.noarch * foreman-libvirt-1.6.0.42-1.el6sat.noarch * foreman-ovirt-1.6.0.42-1.el6sat.noarch * foreman-postgresql-1.6.0.42-1.el6sat.noarch * foreman-proxy-1.6.0.30-1.el6sat.noarch * foreman-selinux-1.6.0.14-1.el6sat.noarch * foreman-vmware-1.6.0.42-1.el6sat.noarch * katello-1.5.0-30.el6sat.noarch * katello-ca-1.0-1.noarch * katello-certs-tools-1.5.6-1.el6sat.noarch * katello-installer-0.0.62-1.el6sat.noarch * openldap-2.4.23-34.el6_5.1.x86_64 * openldap-devel-2.4.23-34.el6_5.1.x86_64 * pulp-katello-0.3-4.el6sat.noarch * pulp-nodes-common-2.4.1-0.5.rc1.el6sat.noarch * pulp-nodes-parent-2.4.1-0.5.rc1.el6sat.noarch * pulp-puppet-plugins-2.4.1-0.5.rc1.el6sat.noarch * pulp-puppet-tools-2.4.1-0.5.rc1.el6sat.noarch * pulp-rpm-plugins-2.4.1-0.5.rc1.el6sat.noarch * pulp-selinux-2.4.1-0.5.rc1.el6sat.noarch * pulp-server-2.4.1-0.5.rc1.el6sat.noarch * python-ldap-2.3.10-1.el6.x86_64 * ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch * ruby193-rubygem-runcible-1.1.0-2.el6sat.noarch This was delivered with Satellite 6.0 which was released on 10 September 2014. |