Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1105175 - -1 should not be used to represent "unlimited" for activation keys and host collections
Summary: -1 should not be used to represent "unlimited" for activation keys and host c...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: WebUI
Version: 6.0.3
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: Unspecified
Assignee: Walden Raines
QA Contact: sthirugn@redhat.com
URL: http://projects.theforeman.org/issues...
Whiteboard:
: 1110482 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-05 13:56 UTC by Sachin Ghai
Modified: 2019-09-26 18:14 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-09-11 12:23:17 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 6078 0 None None None 2016-04-22 15:41:57 UTC

Description Sachin Ghai 2014-06-05 13:56:31 UTC 
Description of problem:

Created a host-collection whose value was set to '10' for content-host limit. Later, I updated the limit with "-1", as soon as I type "-1", the text box closes and points to "unlimited" checkbox.

So -1 shouldn't be allowed for content host limit.

Version-Release number of selected component (if applicable):
sat6 beta snap8 (Satellite-6.0.3-RHEL-6-20140604.0)

How reproducible:
always

Steps to Reproduce:
1. create host collection with limit 10
2. update the limit with -1
3.

Actual results:
on updating the limit with -1, ticks the checkbox to unlimited

Expected results:
user shouldn't be allowed to set limit to -1

Additional info:
A related bz #848564
Comment 1 RHEL Program Management 2014-06-05 14:14:10 UTC 
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.
Comment 3 Tom McKay 2014-06-05 14:59:24 UTC 
The internal value of "unlimited" is in fact -1 so this is behaving correctly. The fix is likely to make the UI widget better at preventing values outside of positive integer range plus zero.

This BZ can remain open but I'm moving it to low priority and severity as everything functions correctly.

This may be a duplicate of other BZs having to do with UI widget text field validations.
Comment 4 Walden Raines 2014-06-05 15:10:47 UTC 
(In reply to Tom McKay from comment #3)
> This BZ can remain open but I'm moving it to low priority and severity as
> everything functions correctly.

I would disagree with that.  Our users should not be forced to know that our internal value of "unlimited" is -1.

Using -1 to represent "unlimited" is a poor design to start with and, as far as the user is concerned, -1 should be an invalid value.  From the user's perspective, the checkbox is the only thing that determines whether or not the system group is "unlimited", not some arbitrary and poorly chosen convention.
Comment 5 Walden Raines 2014-06-05 18:26:51 UTC 
http://projects.theforeman.org/issues/6078
Comment 6 Walden Raines 2014-06-09 19:04:38 UTC 
Created redmine issue http://projects.theforeman.org/issues/6127 from this bug
Comment 7 Walden Raines 2014-06-25 18:30:35 UTC 
Changing summary this to reflect system-wide nature of problem.

For both activation keys and host collections we should not use -1 to represent "unlimited". This issue captures the following work:

* Fix the client side UI so that only > 1 limits can be sent
* Fix the server side so that "unlimited" is represented as a boolean and that limit is ignored if true
* Check that candlepin integration still works
Comment 8 Tom McKay 2014-06-26 14:45:42 UTC 
*** Bug 1110482 has been marked as a duplicate of this bug. ***
Comment 9 Walden Raines 2014-06-27 16:13:28 UTC 
PR: https://github.com/Katello/katello/pull/4360
Comment 10 Walden Raines 2014-07-08 20:29:19 UTC 
Moving to POST since upstream bug http://projects.theforeman.org/issues/6514 has been closed
-------------
Walden Raines
This is fixed with https://github.com/Katello/katello/pull/4360
-------------
Walden Raines
Applied in changeset commit:katello|607f4e7fdeefa10091b24a8a06fd2a45939c6038.
Comment 12 sthirugn@redhat.com 2014-09-03 19:18:31 UTC 
Verified.

Version Tested:
GA Snap 7 - Satellite-6.0.4-RHEL-6-20140829.0

* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.9.23-1.el6_5.noarch
* candlepin-common-1.0.1-1.el6_5.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.9.23-1.el6_5.noarch
* candlepin-tomcat6-0.9.23-1.el6_5.noarch
* elasticsearch-0.90.10-6.el6sat.noarch
* foreman-1.6.0.42-1.el6sat.noarch
* foreman-compute-1.6.0.42-1.el6sat.noarch
* foreman-gce-1.6.0.42-1.el6sat.noarch
* foreman-libvirt-1.6.0.42-1.el6sat.noarch
* foreman-ovirt-1.6.0.42-1.el6sat.noarch
* foreman-postgresql-1.6.0.42-1.el6sat.noarch
* foreman-proxy-1.6.0.30-1.el6sat.noarch
* foreman-selinux-1.6.0.14-1.el6sat.noarch
* foreman-vmware-1.6.0.42-1.el6sat.noarch
* katello-1.5.0-30.el6sat.noarch
* katello-ca-1.0-1.noarch
* katello-certs-tools-1.5.6-1.el6sat.noarch
* katello-installer-0.0.62-1.el6sat.noarch
* openldap-2.4.23-34.el6_5.1.x86_64
* openldap-devel-2.4.23-34.el6_5.1.x86_64
* pulp-katello-0.3-4.el6sat.noarch
* pulp-nodes-common-2.4.1-0.5.rc1.el6sat.noarch
* pulp-nodes-parent-2.4.1-0.5.rc1.el6sat.noarch
* pulp-puppet-plugins-2.4.1-0.5.rc1.el6sat.noarch
* pulp-puppet-tools-2.4.1-0.5.rc1.el6sat.noarch
* pulp-rpm-plugins-2.4.1-0.5.rc1.el6sat.noarch
* pulp-selinux-2.4.1-0.5.rc1.el6sat.noarch
* pulp-server-2.4.1-0.5.rc1.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.1.0-2.el6sat.noarch
Comment 13 Bryan Kearney 2014-09-11 12:23:17 UTC 
This was delivered with Satellite 6.0 which was released on 10 September 2014.
Note You need to log in before you can comment on or make changes to this bug.