Bug 1105550
| Summary: | Review Request: kf5-kdoctools - KDE Frameworks 5 Tier 2 addon for documentation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bugs.michael, jeischma, jgrulich, kevin, package-review |
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-12 12:30:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997, 1086148, 1113070 | ||
|
Description
Daniel Vrátil
2014-06-06 11:39:44 UTC
1) License should be LGPLv2+ and MIT
2) E: standard-dir-owned-by-package /usr/share/man/man[1,7,8]
- you should probably use %{_mandir}/man1/ and similar for man7 and man8
3) E: incorrect-fsf-address /usr/share/doc/HTML/*/kdoctools5-common/kde-localised.css
- this is not a blocking issue and upstream already know about it
Fixed license Fixed man pages installation Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdoctools.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdoctools-4.100.0-2.fc20.src.rpm Looks good now, approved. New Package SCM Request ======================= Package Name: kf5-kdoctools Short Description: KDE Frameworks 5 Tier 2 addon for generating documentation Upstream URL: http://www.kde.org Owners: dvratil jgrulich ltinkl rdieter kkofler Branches: InitialCC: Git done (by process-git-requests). > %post -p /sbin/ldconfig > > %postun -p /sbin/ldconfig Why? No shared libs are included in runtime linker's search path. Which packages provide the following directories? /usr/include/KF5/XsltKde /usr/include/KF5 /usr/share/kf5 /usr/share/kf5/kdoctools https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership > %package doc > /usr/share/doc/HTML/af/kdoctools5-common It seems the package ought to require "kd5-filesystem" for these directories. Thanks for spotting these! Fixed in kf5-kdoctools-4.100.0-3 - removed %post and %postun ldconfig as there are no shared libs - fixed directory ownership - -doc subpackges Requires kf5-filesystem Package Change Request ======================= Package Name: kf5-kdoctools New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than Git done (by process-git-requests). |