Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdoctools.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdoctools-4.100.0-1.fc20.src.rpm Description: KDE Frameworks 5 Tier 2 addon for documentation Fedora Account System Username: dvratil
1) License should be LGPLv2+ and MIT 2) E: standard-dir-owned-by-package /usr/share/man/man[1,7,8] - you should probably use %{_mandir}/man1/ and similar for man7 and man8 3) E: incorrect-fsf-address /usr/share/doc/HTML/*/kdoctools5-common/kde-localised.css - this is not a blocking issue and upstream already know about it
Fixed license Fixed man pages installation Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdoctools.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdoctools-4.100.0-2.fc20.src.rpm
Looks good now, approved.
New Package SCM Request ======================= Package Name: kf5-kdoctools Short Description: KDE Frameworks 5 Tier 2 addon for generating documentation Upstream URL: http://www.kde.org Owners: dvratil jgrulich ltinkl rdieter kkofler Branches: InitialCC:
Git done (by process-git-requests).
> %post -p /sbin/ldconfig > > %postun -p /sbin/ldconfig Why? No shared libs are included in runtime linker's search path. Which packages provide the following directories? /usr/include/KF5/XsltKde /usr/include/KF5 /usr/share/kf5 /usr/share/kf5/kdoctools https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership > %package doc > /usr/share/doc/HTML/af/kdoctools5-common It seems the package ought to require "kd5-filesystem" for these directories.
Thanks for spotting these! Fixed in kf5-kdoctools-4.100.0-3 - removed %post and %postun ldconfig as there are no shared libs - fixed directory ownership - -doc subpackges Requires kf5-filesystem
Package Change Request ======================= Package Name: kf5-kdoctools New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than