Bug 1108789

Info from BZ1113433:

> d/s has auto-population of local ISO domain with RHEV Guest Tools iso and virtio-win vfd files. BZ1108789 is RFE for 3.5 to have such feature for oVirt.
> 
> It does not work in oVirt. Couple of (probably) related issues:
> 
> * d/s strings in oVirt code - BZ1113155
> * engine-setup still does not work even if d/s rpms (rhev-guest-tools-iso, virtio-win) are installed, thus to fit d/s strings in oVirt code
> 
> # ls -l /var/lib/exports/iso/5ea770f5-9565-44a7-8c1a-aeb4856ab514/images/11111111-1111-1111-1111-111111111111/
> total 0
> 
> [root@localhost yum.repos.d]# ls -l -d /usr/share/{virtio-win,rhev-guest-tools-iso}
> drwxr-xr-x. 2 root root 4096 Jun 26 09:34 /usr/share/rhev-guest-tools-iso
> drwxr-xr-x. 4 root root 4096 Jun 26 09:34 /usr/share/virtio-win
> 
> # egrep -ni "rhev|virtio-win" /usr/share/ovirt-engine/setup/ovirt_engine_setup/constants.py
> 366:        'virtio-win',
> 368:    RHEV_GUEST_TOOLS_DIR = os.path.join(
> 370:        'rhev-guest-tools-iso',
> 
> Version-Release number of selected component (if applicable):
> 
> 
> How reproducible:
> 
> 
> Steps to Reproduce:
> 1. depends if code has been repaired to have oVirt values for guest tools:
>    - if not: install rhev-guest-tools-iso, virtio-win
>    - if so: ensure ovirt-guest-tools-iso, virtio-win are (i suppose) located
>      in /usr/share/{ovirt-guest-tools-iso,virtio-win}
> 2. engine-setup and select local iso domain
> 3. check local iso domain for its content
> 
> Actual results:
> local iso domain does not contain guest tools iso and virtio-win vfd
> 
> Expected results:
> should be there
> 
> Additional info:

virtio-win is out of ovirt project. i tried my best with BZ1138291

(In reply to Jiri Belka from comment #2)
> virtio-win is out of ovirt project. i tried my best with BZ1138291

Since it seems that virtio-win is now packaged in rpm and distributed via yum repositories, I think we can reconsider this for 3.6 inclusion.

OK, tested w/ https://fedorapeople.org/groups/virt/virtio-win/repo/stable/virtio-win-0.1.96-1.noarch.rpm

[root@vm-37-22 ~]# engine-setup
[ INFO  ] Stage: Initializing
[ INFO  ] Stage: Environment setup
          Configuration files: ['/etc/ovirt-engine-setup.conf.d/10-packaging-jboss.conf', '/etc/ovirt-engine-setup.conf.d/10-packaging.conf']
          Log file: /var/log/ovirt-engine/setup/ovirt-engine-setup-20150609174204-tn1d55.log
          Version: otopi-1.4.0_master (otopi-1.4.0-0.0.master.20150423125506.git08ea44e.el6)
[ INFO  ] Stage: Environment packages setup
[ INFO  ] Stage: Programs detection
[ INFO  ] Stage: Environment setup
[ INFO  ] Stage: Environment customization
         
          --== PRODUCT OPTIONS ==--
         
          Configure Engine on this host (Yes, No) [Yes]: 
          Configure WebSocket Proxy on this host (Yes, No) [Yes]: 
         
          --== PACKAGES ==--
         
[ INFO  ] Checking for product updates...
[ INFO  ] No product updates found
         
          --== ALL IN ONE CONFIGURATION ==--
         
         
          --== NETWORK CONFIGURATION ==--
         
          Host fully qualified DNS name of this server [vm-37-22.ci.lab.tlv.redhat.com]: 
          Setup can automatically configure the firewall on this system.
          Note: automatic configuration of the firewall may overwrite current settings.
          Do you want Setup to configure the firewall? (Yes, No) [Yes]: 
          The following firewall managers were detected on this system: iptables
          Firewall manager to configure (iptables): iptables
[ INFO  ] iptables will be configured as firewall manager.
         
          --== DATABASE CONFIGURATION ==--
         
          Where is the Engine database located? (Local, Remote) [Local]: 
          Setup can configure the local postgresql server automatically for the engine to run. This may conflict with existing applications.
          Would you like Setup to automatically configure postgresql and create Engine database, or prefer to perform that manually? (Automatic, Manual) [Automatic]: 
         
          --== OVIRT ENGINE CONFIGURATION ==--
         
          Engine admin password: 
          Confirm engine admin password: 
[WARNING] Password is weak: it is too simplistic/systematic
          Use weak password? (Yes, No) [No]: Yes
          Application mode (Virt, Gluster, Both) [Both]: 
         
          --== STORAGE CONFIGURATION ==--
         
          Default SAN wipe after delete (Yes, No) [No]: 
         
          --== PKI CONFIGURATION ==--
         
          Organization name for certificate [ci.lab.tlv.redhat.com]: 
         
          --== APACHE CONFIGURATION ==--
         
          Setup can configure apache to use SSL using a certificate issued from the internal CA.
          Do you wish Setup to configure that, or prefer to perform that manually? (Automatic, Manual) [Automatic]: 
          Setup can configure the default page of the web server to present the application home page. This may conflict with existing applications.
          Do you wish to set the application as the default page of the web server? (Yes, No) [Yes]: 
         
          --== SYSTEM CONFIGURATION ==--
         
          Configure an NFS share on this server to be used as an ISO Domain? (Yes, No) [Yes]: 
          Local ISO domain path [/var/lib/exports/iso]: 
         
          Please provide the ACL for the Local ISO domain.
          See the exports(5) manpage for the format.
          Examples:
          - To allow access for host1, host2 and host3, input: host1(rw) host2(rw) host3(rw)
          - To allow access to the entire Internet, input: *(rw)
         
          For more information, see: http://www.ovirt.org/Troubleshooting_NFS_Storage_Issues
         
          Local ISO domain ACL: *(rw)
          Local ISO domain name [ISO_DOMAIN]: 
         
          --== MISC CONFIGURATION ==--
         
         
          --== END OF CONFIGURATION ==--
         
[ INFO  ] Stage: Setup validation
          Generated iptables rules are different from current ones.
          Do you want to review them? (Yes, No) [No]: 
[WARNING] Less than 16384MB of memory is available
         
          --== CONFIGURATION PREVIEW ==--
         
          Application mode                        : both
          Firewall manager                        : iptables
          Update Firewall                         : True
          Host FQDN                               : vm-37-22.ci.lab.tlv.redhat.com
          Default SAN wipe after delete           : False
          Engine database secured connection      : False
          Engine database host                    : localhost
          Engine database user name               : engine
          Engine database name                    : engine
          Engine database port                    : 5432
          Engine database host name validation    : False
          Engine installation                     : True
          NFS setup                               : True
          PKI organization                        : ci.lab.tlv.redhat.com
          NFS mount point                         : /var/lib/exports/iso
          NFS export ACL                          : *(rw)
          Configure local Engine database         : True
          Set application as default page         : True
          Configure Apache SSL                    : True
          Configure WebSocket Proxy               : True
          Engine Host FQDN                        : vm-37-22.ci.lab.tlv.redhat.com
         
          Please confirm installation settings (OK, Cancel) [OK]: 
[ INFO  ] Stage: Transaction setup
[ INFO  ] Stopping engine service
[ INFO  ] Stopping ovirt-fence-kdump-listener service
[ INFO  ] Stopping websocket-proxy service
[ INFO  ] Stage: Misc configuration
[ INFO  ] Stage: Package installation
[ INFO  ] Stage: Misc configuration
[ INFO  ] Initializing PostgreSQL
[ INFO  ] Creating PostgreSQL 'engine' database
[ INFO  ] Configuring PostgreSQL
[ INFO  ] Creating/refreshing Engine database schema
[ INFO  ] Creating CA
[ INFO  ] Configuring WebSocket Proxy
[ INFO  ] Generating post install configuration file '/etc/ovirt-engine-setup.conf.d/20-setup-ovirt-post.conf'
[ INFO  ] Stage: Transaction commit
[ INFO  ] Stage: Closing up
[ INFO  ] Restarting nfs services
         
          --== SUMMARY ==--
         
[WARNING] Less than 16384MB of memory is available
          SSH fingerprint: 4C:FB:AA:A0:7C:40:6B:9D:6E:BF:23:F1:A4:68:4B:ED
          Internal CA 19:5E:B8:28:9A:A7:83:70:54:C5:28:E2:EC:E9:76:B1:33:64:AA:B4
          Note! If you want to gather statistical information you can install Reports and/or DWH:
              http://www.ovirt.org/Ovirt_DWH
              http://www.ovirt.org/Ovirt_Reports
          Web access is enabled at:
              http://vm-37-22.ci.lab.tlv.redhat.com:80/ovirt-engine
              https://vm-37-22.ci.lab.tlv.redhat.com:443/ovirt-engine
          Please use the user "admin" and password specified in order to login
         
          --== END OF SUMMARY ==--
         
[ INFO  ] Starting engine service
[ INFO  ] Restarting httpd
[ INFO  ] Stage: Clean up
          Log file is located at /var/log/ovirt-engine/setup/ovirt-engine-setup-20150609174204-tn1d55.log
[ INFO  ] Generating answer file '/var/lib/ovirt-engine/setup/answers/20150609174507-setup.conf'
[ INFO  ] Stage: Pre-termination
[ INFO  ] Stage: Termination
[ INFO  ] Execution of setup completed successfully

# ll /var/lib/exports/iso/cb822279-be31-497e-b582-022c6e3a031a/images/11111111-1111-1111-1111-111111111111
total 268100
-rw-r--r--. 1 vdsm kvm 107974656 Jun  9 17:44 ovirt-tools-setup.iso
-rw-r--r--. 1 vdsm kvm   2949120 Jun  9 17:44 virtio-win_amd64.vfd
-rw-r--r--. 1 vdsm kvm 160659456 Jun  9 17:44 virtio-win.iso
-rw-r--r--. 1 vdsm kvm   2949120 Jun  9 17:44 virtio-win_x86.vfd

ok

[root@jb-rhevm35 yum.repos.d]# rpm -q ovirt-engine ovirt-guest-tools-iso virtio-win
ovirt-engine-3.6.2-0.0.master.20151220173830.git5f8000c.el6.noarch
ovirt-guest-tools-iso-3.6.0-0.2_master.fc22.noarch
virtio-win-0.1.102-1.noarch
[root@jb-rhevm35 yum.repos.d]# find /var/lib/exports/iso/
/var/lib/exports/iso/
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/dom_md
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/dom_md/leases
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/dom_md/ids
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/dom_md/metadata
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/dom_md/inbox
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/dom_md/outbox
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/images
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/images/11111111-1111-1111-1111-111111111111
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/images/11111111-1111-1111-1111-111111111111/virtio-win.iso
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/images/11111111-1111-1111-1111-111111111111/virtio-win_amd64.vfd
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/images/11111111-1111-1111-1111-111111111111/.keep
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/images/11111111-1111-1111-1111-111111111111/ovirt-tools-setup.iso
/var/lib/exports/iso/af60f23f-3c8b-4514-a528-cf8f0404ad91/images/11111111-1111-1111-1111-111111111111/virtio-win_x86.vfd

oVirt 3.6.0 has been released and the bz verified, moving to closed current release.