Bug 1111982 (kf5-khtml)

Summary: Review Request: kf5-khtml - KDE Frameworks 5 Tier 4 solution with KHTML, a HTML rendering engine
Product: [Fedora] Fedora Reporter: Daniel Vrátil <dvratil>
Component: Package ReviewAssignee: Jan Grulich <jgrulich>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jeischma, jgrulich, package-review
Target Milestone: ---Flags: jgrulich: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-07-07 15:11:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1108810, 1108812, 1108817, 1108824, 1108830, 1111948, 1111952    
Bug Blocks: 656997, 1086148    

Description Daniel Vrátil 2014-06-22 13:22:57 UTC
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-khtml.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-khtml-4.100.0-1.fc20.src.rpm
Description: KHTML is a web rendering engine, based on the KParts technology and using KJS for JavaScript support.
Fedora Account System Username: dvratil

Comment 1 Jan Grulich 2014-07-07 12:25:01 UTC
1) Missing BSD and MIT licenses
2) Missing %config at the beginning of line with /etc/xdg/khtmlrc in %files
3) Wrong url for the source
4) Not sure what to do with a bundled .jar file installed to kjava directory, but kdelibs4 also installs it, so there is probably nothing what needs to be done

Comment 2 Daniel Vrátil 2014-07-07 12:44:44 UTC
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-khtml.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-khtml-4.100.0-2.fc20.src.rpm

- Fixed license
- Fixed installation of config files
- Fixed Source0 URL

Comment 3 Jan Grulich 2014-07-07 12:58:39 UTC
Looks good now, approved.

Comment 4 Daniel Vrátil 2014-07-07 12:59:12 UTC
New Package SCM Request
=======================
Package Name: kf5-khtml
Short Description: KDE Frameworks 5 Tier 4 solution with KHTML, a HTML rendering engine
Upstream URL: http://www.kde.org
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Branches: 
InitialCC:

Comment 5 Gwyn Ciesla 2014-07-07 13:35:50 UTC
Git done (by process-git-requests).

Comment 6 Daniel Vrátil 2014-09-25 08:36:49 UTC
Package Change Request
=======================
Package Name: 
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than

Comment 7 Daniel Vrátil 2014-09-25 09:06:27 UTC
Package Change Request
=======================
Package Name: kf5-khtml
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than

Comment 8 Gwyn Ciesla 2014-09-25 13:16:32 UTC
Git done (by process-git-requests).