Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-khtml.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-khtml-4.100.0-1.fc20.src.rpm Description: KHTML is a web rendering engine, based on the KParts technology and using KJS for JavaScript support. Fedora Account System Username: dvratil
1) Missing BSD and MIT licenses 2) Missing %config at the beginning of line with /etc/xdg/khtmlrc in %files 3) Wrong url for the source 4) Not sure what to do with a bundled .jar file installed to kjava directory, but kdelibs4 also installs it, so there is probably nothing what needs to be done
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-khtml.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-khtml-4.100.0-2.fc20.src.rpm - Fixed license - Fixed installation of config files - Fixed Source0 URL
Looks good now, approved.
New Package SCM Request ======================= Package Name: kf5-khtml Short Description: KDE Frameworks 5 Tier 4 solution with KHTML, a HTML rendering engine Upstream URL: http://www.kde.org Owners: dvratil ltinkl jgrulich kkofler rdieter than Branches: InitialCC:
Git done (by process-git-requests).
Package Change Request ======================= Package Name: New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than
Package Change Request ======================= Package Name: kf5-khtml New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than