Bug 1116048

Summary: if connection to spice proxy fails, mention in log message that the failed connection was to the proxy
Product: Red Hat Enterprise Linux 7 Reporter: David Jaša <djasa>
Component: spice-gtkAssignee: Marc-Andre Lureau <marcandre.lureau>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: low Docs Contact:
Priority: unspecified    
Version: 7.0CC: dblechte, jjongsma, marcandre.lureau, mkrcmari, rbalakri
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: spice-gtk-0.22-2.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-05 13:41:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1115986    

Description David Jaša 2014-07-03 14:55:56 UTC 
Description of problem:
There is no difference in error message between connection failure to destination server or http proxy along the way. These messages should be differentiated

Version-Release number of selected component (if applicable):
spice-gtk3-0.20-8.el7.x86_64

How reproducible:
always

Steps to Reproduce:
run
$ SPICE_PROXY=nonsense.example.com remote-viewer spice://nonsense.example.com:5900/
$ remote-viewer spice://nonsense.example.com:5900/

Actual results:
ouptut in both cases is:
(remote-viewer:LINE_NO): GSpice-WARNING **: Error resolving 'nonsense.example.com': Name or service not known
The only difference is line number (24579 vs 24587)

Expected results:
The messages are sufficiently different to tell apart if failed connection to the proxy or to the server

Additional info:
Comment 1 Marc-Andre Lureau 2014-07-03 15:23:05 UTC 

(In reply to David Jaša from comment #0)
> Steps to Reproduce:
> run
> $ SPICE_PROXY=nonsense.example.com remote-viewer
> spice://nonsense.example.com:5900/
> $ remote-viewer spice://nonsense.example.com:5900/
> 
> Actual results:
> ouptut in both cases is:
> (remote-viewer:LINE_NO): GSpice-WARNING **: Error resolving
> 'nonsense.example.com': Name or service not known
> The only difference is line number (24579 vs 24587)

It's not lineno, it's pid :)

> 
> Expected results:
> The messages are sufficiently different to tell apart if failed connection
> to the proxy or to the server
> 
> Additional info:

Just for info, firefox for example has a different error for proxy:

"Unable to find the proxy server

Firefox is configured to use a proxy server that can't be found."
Comment 2 Marc-Andre Lureau 2014-07-06 22:37:46 UTC 
http://lists.freedesktop.org/archives/spice-devel/2014-July/017033.html
Comment 3 Jonathon Jongsma 2014-09-12 16:14:28 UTC 
*** Bug 1140870 has been marked as a duplicate of this bug. ***
Comment 4 Jonathon Jongsma 2014-09-12 16:15:44 UTC 
relevant upstream commits:

3edcc04f20b8e2360a05e16c337b26404f636081
556ebfe949415b217104b51077da0b95da7726c4
Comment 7 Jonathon Jongsma 2014-09-17 15:14:51 UTC 
*** Bug 1140870 has been marked as a duplicate of this bug. ***
Comment 11 errata-xmlrpc 2015-03-05 13:41:03 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0297.html