Bug 1120366
| Summary: | Review Request: nodejs-set-immediate - A shim for the setImmediate API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom Hughes <tom> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-17 17:31:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 956806, 1120117 | ||
|
Description
Tom Hughes
2014-07-16 19:13:20 UTC
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see attached
diff).
See: (this test has no URL)
Diff spec file in url and in SRPM
---------------------------------
--- /home/parag/1120366-nodejs-set-immediate/srpm/nodejs-set-immediate.spec 2014-07-17 08:37:20.243230431 +0530
+++ /home/parag/1120366-nodejs-set-immediate/srpm-unpacked/nodejs-set-immediate.spec 2014-07-16 23:46:42.000000000 +0530
@@ -7,7 +7,7 @@
URL: https://github.com/jussi-kalliokoski/setImmediate.js
Source0: http://registry.npmjs.org/set-immediate/-/set-immediate-%{version}.tgz
-# https://github.com/jussi-kalliokoski/setImmediate.js/pull/5
+#
Source1: nodejs-set-immediate-license.txt
-# https://github.com/jussi-kalliokoski/setImmediate.js/pull/4
+#
Patch0: nodejs-set-immediate-test.patch
BuildArch: noarch
Please fix above issue for further review.
I've rebuilt the srpm with the updated spec: Spec URL: http://download.compton.nu/nodejs/nodejs-set-immediate.spec SRPM URL: http://download.compton.nu/nodejs/nodejs-set-immediate-0.1.1-1.fc20.src.rpm Review: + mock build is successful for f22 + rpmlint output on rpms gave nodejs-set-immediate.noarch: W: spelling-error Summary(en_US) setImmediate -> set Immediate, set-immediate, immediateness nodejs-set-immediate.noarch: W: spelling-error %description -l en_US setImmediate -> set Immediate, set-immediate, immediateness nodejs-set-immediate.noarch: W: only-non-binary-in-usr-lib nodejs-set-immediate.src: W: spelling-error Summary(en_US) setImmediate -> set Immediate, set-immediate, immediateness nodejs-set-immediate.src: W: spelling-error %description -l en_US setImmediate -> set Immediate, set-immediate, immediateness 2 packages and 0 specfiles checked; 0 errors, 5 warnings. ==> Not a issue + Source verified with upstream as (sha256sum) srpm tarball :f30ca71c7b81a9d32163e09cd1aa40d83f7772c6de9f416d3a9d374419dda4d2 upstream tarball :f30ca71c7b81a9d32163e09cd1aa40d83f7772c6de9f416d3a9d374419dda4d2 + License "MIT" is valid and included in separate text file as patch + rest looks Ok Suggestion: 1) cp command in %prep should preserve timestamp though its not a upstream file. APPROVED. New Package SCM Request ======================= Package Name: nodejs-set-immediate Short Description: A shim for the setImmediate API Owners: tomh jamielinux Branches: f19 f20 f21 InitialCC: Git done (by process-git-requests). |