Hide Forgot
Spec URL: http://download.compton.nu/nodejs/nodejs-set-immediate.spec SRPM URL: http://download.compton.nu/nodejs/nodejs-set-immediate-0.1.1-1.fc20.src.rpm Fedora Account System Username: tomh Description: A simple and lightweight shim for the setImmediate W3C Draft API, for use in any browsers and NodeJS.
[!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) Diff spec file in url and in SRPM --------------------------------- --- /home/parag/1120366-nodejs-set-immediate/srpm/nodejs-set-immediate.spec 2014-07-17 08:37:20.243230431 +0530 +++ /home/parag/1120366-nodejs-set-immediate/srpm-unpacked/nodejs-set-immediate.spec 2014-07-16 23:46:42.000000000 +0530 @@ -7,7 +7,7 @@ URL: https://github.com/jussi-kalliokoski/setImmediate.js Source0: http://registry.npmjs.org/set-immediate/-/set-immediate-%{version}.tgz -# https://github.com/jussi-kalliokoski/setImmediate.js/pull/5 +# Source1: nodejs-set-immediate-license.txt -# https://github.com/jussi-kalliokoski/setImmediate.js/pull/4 +# Patch0: nodejs-set-immediate-test.patch BuildArch: noarch Please fix above issue for further review.
I've rebuilt the srpm with the updated spec: Spec URL: http://download.compton.nu/nodejs/nodejs-set-immediate.spec SRPM URL: http://download.compton.nu/nodejs/nodejs-set-immediate-0.1.1-1.fc20.src.rpm
Review: + mock build is successful for f22 + rpmlint output on rpms gave nodejs-set-immediate.noarch: W: spelling-error Summary(en_US) setImmediate -> set Immediate, set-immediate, immediateness nodejs-set-immediate.noarch: W: spelling-error %description -l en_US setImmediate -> set Immediate, set-immediate, immediateness nodejs-set-immediate.noarch: W: only-non-binary-in-usr-lib nodejs-set-immediate.src: W: spelling-error Summary(en_US) setImmediate -> set Immediate, set-immediate, immediateness nodejs-set-immediate.src: W: spelling-error %description -l en_US setImmediate -> set Immediate, set-immediate, immediateness 2 packages and 0 specfiles checked; 0 errors, 5 warnings. ==> Not a issue + Source verified with upstream as (sha256sum) srpm tarball :f30ca71c7b81a9d32163e09cd1aa40d83f7772c6de9f416d3a9d374419dda4d2 upstream tarball :f30ca71c7b81a9d32163e09cd1aa40d83f7772c6de9f416d3a9d374419dda4d2 + License "MIT" is valid and included in separate text file as patch + rest looks Ok Suggestion: 1) cp command in %prep should preserve timestamp though its not a upstream file. APPROVED.
New Package SCM Request ======================= Package Name: nodejs-set-immediate Short Description: A shim for the setImmediate API Owners: tomh jamielinux Branches: f19 f20 f21 InitialCC:
Git done (by process-git-requests).