Bug 1132051

Summary: RemoteAgentInstall SSH filetransfer errors are ignored
Product: [JBoss] JBoss Operations Network Reporter: Michael Burman <miburman>
Component: AgentAssignee: Michael Burman <miburman>
Status: CLOSED CURRENTRELEASE QA Contact: Armine Hovsepyan <ahovsepy>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: JON 3.3.0CC: ahovsepy, hrupp, jshaughn, mfoley
Target Milestone: ER02   
Target Release: JON 3.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1132049 Environment:
Last Closed: 2014-12-11 14:02:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1132049    
Bug Blocks: 1070242, 1131495    
Attachments:
Description Flags
no-permission none

Description Michael Burman 2014-08-20 14:38:47 UTC 
+++ This bug was initially created as a clone of Bug #1132049 +++

Description of problem: If there's an error when trying to scp files on the remote agent install, these errors are forgotten and the user gets "Agent Installation Completed" message.


Version-Release number of selected component (if applicable): 4.13 / JON3.3.ER01


How reproducible: Always
 

Steps to Reproduce:
1. Try to install agent to a directory that can't be accessed
2. 
3.

Actual results: "Agent installation completed", "Global uncaught exception" messages are presented to the user. No agent is installed.


Expected results: User would get an error message indicating that file could not be transferred to the destination.


Additional info:
Comment 1 Michael Burman 2014-08-28 20:54:05 UTC 
Fixed in master:

commit 66effaa0b473c133c4f1e667b0bea4436d85cbff
Merge: 7bef780 c1fdabc
Author: John Mazzitelli <mazz>
Date:   Thu Aug 28 16:17:59 2014 -0400

    Merge pull request #114 from burmanm/remote_agent
    
    Modify remote agent install UI and make userfriendlier error messages

commit c1fdabc180a8b63d43813d4640b24b686f2aad44
Author: Michael Burman <miburman>
Date:   Wed Aug 20 17:29:05 2014 +0300

    [BZ 1131495] Refactor SSHInstallUtility to catch error messages and throw exceptions if operations fail, instead of returning just Failed te
    
    [BZ 1132051] Catch scp errors when installing to get proper error message for missing permissions.
    
    [BZ 1128772] Catch some basic error messages and create a friendlier layout for them
    
    [BZ 1128779] After the agent has been installed, refresh the UI to show only relevant information.
    
    [BZ 1128782] While installing, show window which indicates the installation is running
Comment 2 Jay Shaughnessy 2014-08-29 17:40:39 UTC 
Release/jon3.3.x commit 83f133d17ce4eb377fc2b398b109c41da3ef6c6e
Author: John Mazzitelli <mazz>
Date:   Thu Aug 28 16:17:59 2014 -0400

    Merge pull request #114 from burmanm/remote_agent
    Signed-off-by: Jay Shaughnessy <jshaughn>
Comment 3 Simeon Pinder 2014-09-03 20:31:31 UTC 
Moving to ON_QA as available for test with the following brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=381194
Comment 4 Armine Hovsepyan 2014-09-10 14:26:01 UTC 
Created attachment 936199 [details]
no-permission
Comment 5 Armine Hovsepyan 2014-09-10 14:26:50 UTC 
verified in JON 3.3 ER02
screen-shot attached