Bug 1136522
| Summary: | Use HarfBuzz | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Kuhn <suraia> | ||||||
| Component: | freetype | Assignee: | Marek Kašík <mkasik> | ||||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | behdad, fonts-bugs, kevin, mkasik, rdieter, redhat-bugzilla | ||||||
| Target Milestone: | --- | Keywords: | FutureFeature | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Enhancement | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2021-03-03 16:54:13 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Note that this introduces a circular dependency since harfbuzz requires freetype to build. (In reply to Behdad Esfahbod from comment #1) > Note that this introduces a circular dependency since harfbuzz requires > freetype to build. Yes, this is the reason why I haven't turned it on yet. I'll look at it again once this is solved upstream. Regards Marek Created attachment 934031 [details]
Use HarfBuzz
Yes, building the package(s) from scratch requires one extra step:
1. Build freetype with --define 'with_harfbuzz 0'
2. Build harfbuzz
3. Build freetype
What would be your preferred way of solving this? Loading HarfBuzz dynamically in FreeType?
I also just noticed that the original patch included a typo for the "with_harfbuzz 0" case; I am attaching a fixed version for completeness.
> What would be your preferred way of solving this? Loading HarfBuzz
> dynamically in FreeType?
… which would obviously not solve the build time issues. Sorry, I guess I was not fully awake when writing this. :-)
I don't have a preferred way for this right now unfortunately. :( Fedora has bootstrapping guidelines, https://fedoraproject.org/wiki/Packaging:Guidelines#Bootstrapping that could be used here. Hi, I've enabled the support for HarfBuzz in FreeType in Fedora 34 via https://bugzilla.redhat.com/show_bug.cgi?id=1906714. I'm closing this as a duplicate of it. Regards. *** This bug has been marked as a duplicate of bug 1906714 *** |
Created attachment 933896 [details] Use HarfBuzz Description of problem: FreeType can use HarfBuzz to provide improved hinting. The attached patch adds a new with_harfbuzz flag that enables building FreeType with HarfBuzz support. (It is currently set to 1 but can easily be set to 0 to disable it by default.)