Created attachment 933896 [details]
Description of problem:
FreeType can use HarfBuzz to provide improved hinting.
The attached patch adds a new with_harfbuzz flag that enables building FreeType with HarfBuzz support. (It is currently set to 1 but can easily be set to 0 to disable it by default.)
Note that this introduces a circular dependency since harfbuzz requires freetype to build.
(In reply to Behdad Esfahbod from comment #1)
> Note that this introduces a circular dependency since harfbuzz requires
> freetype to build.
Yes, this is the reason why I haven't turned it on yet. I'll look at it again once this is solved upstream.
Created attachment 934031 [details]
Yes, building the package(s) from scratch requires one extra step:
1. Build freetype with --define 'with_harfbuzz 0'
2. Build harfbuzz
3. Build freetype
What would be your preferred way of solving this? Loading HarfBuzz dynamically in FreeType?
I also just noticed that the original patch included a typo for the "with_harfbuzz 0" case; I am attaching a fixed version for completeness.
> What would be your preferred way of solving this? Loading HarfBuzz
> dynamically in FreeType?
… which would obviously not solve the build time issues. Sorry, I guess I was not fully awake when writing this. :-)
I don't have a preferred way for this right now unfortunately. :(
Fedora has bootstrapping guidelines,
that could be used here.