Bug 1136830

+++ This bug was initially created as a clone of Bug #1132469 +++

Description of problem:

When an inode's type is mismatching across the subvolumes of AFR, operations on it must not succeed and must fail with EIO.

Version-Release number of selected component (if applicable):
AFR-V2

How reproducible:
Always

Steps to Reproduce:
1. Create, start and mount a replicate volume.
2. 'mkdir foo' on the mountpoint.
3. Go to one of the bricks, do 'rm -rf foo', and perform 'touch foo'.
4. Perform 'ls -lR' on the mount point. Observe file type.

Actual results:

No error is reported on the mountpoint.
The inode is listed as a regular file.
But a stat on foo reports that foo is a directory.
echo 123 > /mnt/foo fails with EISDIR.
mkdir foo/bar succeeds.
From this point on, foo is listed as directory on doing ls -l.
foo continues to be a regular file on the brick where step 3 was performed.

Expected results:
Operations on such an inode where the replicas are not in agreement with respect to its type, must fail with EIO.

Additional info:
The test returns EIO (as expected) on AFR-V1.

--- Additional comment from Anand Avati on 2014-09-01 07:18:04 EDT ---

REVIEW: http://review.gluster.org/8574 (cluster/afr: Propagate EIO on inode's type mismatch) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Anand Avati on 2014-09-02 04:34:45 EDT ---

REVIEW: http://review.gluster.org/8574 (cluster/afr: Propagate EIO on inode's type mismatch) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Anand Avati on 2014-09-02 08:47:51 EDT ---

REVIEW: http://review.gluster.org/8574 (cluster/afr: Propagate EIO on inode's type mismatch) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Anand Avati on 2014-09-02 10:57:31 EDT ---

COMMIT: http://review.gluster.org/8574 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 6c4325ca57bca72d10e5172f8423262cdb3a379c
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Aug 21 17:27:17 2014 +0530

    cluster/afr: Propagate EIO on inode's type mismatch
    
    Original author of the test script:
                Pranith Kumar K <pkarampu>
    
    Change-Id: If515ecefd3c17f85f175b6a8cb4b78ce8c916de2
    BUG: 1132469
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/8574
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>

--- Additional comment from Anand Avati on 2014-09-03 05:08:06 EDT ---

REVIEW: http://review.gluster.org/8586 (cluster/afr: Minor fixes to #8574) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Anand Avati on 2014-09-03 07:10:41 EDT ---

COMMIT: http://review.gluster.org/8586 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 1f094f2519c163bd033ab535555448db34e9804d
Author: Krutika Dhananjay <kdhananj>
Date:   Tue Sep 2 21:05:56 2014 +0530

    cluster/afr: Minor fixes to #8574
    
    * Fixed a bug in afr_selfheal_name_type_mismatch_check()
    * Fixed indentation
    * Removed redundant 'continue' statements
    
    Change-Id: Ie58b5dec9085ce9fe46ae9f244ebae1b1cef7ac5
    BUG: 1132469
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/8586
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>