Bug 1139007

Summary:	Review Request: perl-Sentinel - Create lightweight SCALARs with get/set callbacks
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	David Dick <ddick>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ddick, package-review
Target Milestone:	---	Flags:	ddick: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-09-08 19:26:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1139009

Description Emmanuel Seyman 2014-09-07 12:31:59 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Sentinel/perl-Sentinel.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Sentinel/perl-Sentinel-0.05-1.fc20.src.rpm

Description:
This module provides a single lvalue function, sentinel, which yields a
scalar that invoke callbacks to get or set its value. Primarily this is
useful to create lvalue object accessors or other functions, to invoke
actual code when a new value is set, rather than simply updating a
scalar variable.

Fedora Account System Username: eseyman

Rpmlint output : 1 packages and 1 specfiles checked; 0 errors, 2 warnings.

Comment 1 David Dick 2014-09-07 20:57:50 UTC

License is good.

Package builds in rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=7541099

Missing BRs

BR: perl(strict)
BR: perl(warnings)
BR: perl(Scalar::Util)
BR: perl(constant)
BR: perl(Test::Pod)
BR: perl(Exporter)
BR: perl(XSLoader)

Also

Require: perl(XSLoader)

Add "find $RPM_BUILD_ROOT -type f -name '*.bs' -size 0 -exec rm -f {} \;" to %install to fix rpmlint error message

Comment 2 Emmanuel Seyman 2014-09-07 21:20:53 UTC

Done.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Sentinel/perl-Sentinel.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Sentinel/perl-Sentinel-0.05-2.fc20.src.rpm

Comment 3 David Dick 2014-09-07 21:37:41 UTC

Ack.

Successful build at http://koji.fedoraproject.org/koji/taskinfo?taskID=7541336

Package Approved

Comment 4 Emmanuel Seyman 2014-09-07 21:48:32 UTC

Thanks for the review, David. Requesting SCM.

New Package SCM Request
=======================
Package Name: perl-Sentinel
Short Description: Create lightweight SCALARs with get/set callbacks
Upstream URL: http://search.cpan.org/dist/Sentinel/
Owners: eseyman
Branches: f20 f21
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2014-09-08 12:24:47 UTC

Git done (by process-git-requests).

Comment 6 Emmanuel Seyman 2014-09-08 19:26:16 UTC

Built on all branches. Thank you, Jon and David.