Spec URL: http://people.parinux.org/~seyman/fedora/perl-LV/perl-LV.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-LV/perl-LV-0.006-1.fc20.src.rpm Description: This module makes lvalue subroutines easy and practical to use. It's inspired by the lvalue module which is sadly problematic because of the existence of another module on CPAN called Lvalue. Fedora Account System Username: eseyman Rpmlint output : 1 packages and 1 specfiles checked; 0 errors, 2 warnings.
Could we get a more descriptive summary? You could substitute PERL_INSTALL_ROOT with the standard DESTDIR. You could drop line 41; it's unnecessary nowadays. You're missing some BRs, namely: - Carp, lib/LV/Backend/Magic.pm:10, via 04magic.t - Exporter, lib/LV.pm:16, via 01basic.t - strict, used by everything - Variable::Magic, lib/LV/Backend/Magic.pm:11, via 04magic.t -> lib/LV.pm:46 - warnings, used by everything Both 03sentinel.t and 04magic.t will skip their plans if the backend modules cannot be loaded, therefore Carp, Sentinel and Variable::Magic are optional. However, it'd be a good idea to run those tests anyway.
(In reply to Petr Šabata from comment #1) > > Could we get a more descriptive summary? Done. > You could substitute PERL_INSTALL_ROOT with the standard DESTDIR. Done. > You could drop line 41; it's unnecessary nowadays. Line 36 removed. > You're missing some BRs, namely: > - Carp, lib/LV/Backend/Magic.pm:10, via 04magic.t > - Exporter, lib/LV.pm:16, via 01basic.t > - strict, used by everything > - Variable::Magic, lib/LV/Backend/Magic.pm:11, via 04magic.t -> lib/LV.pm:46 > - warnings, used by everything All added. Spec URL: http://people.parinux.org/~seyman/fedora/perl-LV/perl-LV.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-LV/perl-LV-0.006-2.fc20.src.rpm
Okay, approving.
New Package SCM Request ======================= Package Name: perl-LV Short Description: Perl module to make lvalue subroutines easy and practical Upstream URL: http://search.cpan.org/dist/LV/ Owners: eseyman Branches: f21 f20 InitialCC: perl-sig
Git done (by process-git-requests).
Built in Rawhide.