Bug 1139007 - Review Request: perl-Sentinel - Create lightweight SCALARs with get/set callbacks
Summary: Review Request: perl-Sentinel - Create lightweight SCALARs with get/set callb...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Dick
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1139009
TreeView+ depends on / blocked
 
Reported: 2014-09-07 12:31 UTC by Emmanuel Seyman
Modified: 2014-09-08 19:26 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-09-08 19:26:16 UTC
Type: ---
Embargoed:
ddick: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2014-09-07 12:31:59 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Sentinel/perl-Sentinel.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Sentinel/perl-Sentinel-0.05-1.fc20.src.rpm

Description:
This module provides a single lvalue function, sentinel, which yields a
scalar that invoke callbacks to get or set its value. Primarily this is
useful to create lvalue object accessors or other functions, to invoke
actual code when a new value is set, rather than simply updating a
scalar variable.

Fedora Account System Username: eseyman

Rpmlint output : 1 packages and 1 specfiles checked; 0 errors, 2 warnings.

Comment 1 David Dick 2014-09-07 20:57:50 UTC
License is good.

Package builds in rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=7541099

Missing BRs

BR: perl(strict)
BR: perl(warnings)
BR: perl(Scalar::Util)
BR: perl(constant)
BR: perl(Test::Pod)
BR: perl(Exporter)
BR: perl(XSLoader)

Also

Require: perl(XSLoader)

Add "find $RPM_BUILD_ROOT -type f -name '*.bs' -size 0 -exec rm -f {} \;" to %install to fix rpmlint error message

Comment 3 David Dick 2014-09-07 21:37:41 UTC
Ack.

Successful build at http://koji.fedoraproject.org/koji/taskinfo?taskID=7541336

Package Approved

Comment 4 Emmanuel Seyman 2014-09-07 21:48:32 UTC
Thanks for the review, David. Requesting SCM.

New Package SCM Request
=======================
Package Name: perl-Sentinel
Short Description: Create lightweight SCALARs with get/set callbacks
Upstream URL: http://search.cpan.org/dist/Sentinel/
Owners: eseyman
Branches: f20 f21
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2014-09-08 12:24:47 UTC
Git done (by process-git-requests).

Comment 6 Emmanuel Seyman 2014-09-08 19:26:16 UTC
Built on all branches. Thank you, Jon and David.


Note You need to log in before you can comment on or make changes to this bug.