Bug 1144407

Summary:	Disperse xlator issues in a 32 bits environment
Product:	[Community] GlusterFS	Reporter:	Xavi Hernandez <jahernan>
Component:	disperse	Assignee:	Xavi Hernandez <jahernan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.6.0	CC:	bugs, gluster-bugs, ndevos
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1125312	Environment:
Last Closed:	2014-11-11 08:39:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1125312
Bug Blocks:	1117822

Description Xavi Hernandez 2014-09-19 10:09:12 UTC

+++ This bug was initially created as a clone of Bug #1125312 +++

Description of problem:

EC xlator doesn't work correctly when compiled with 32 bits.

Version-Release number of selected component (if applicable): master


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-09-15 12:02:59 CEST ---

REVIEW: http://review.gluster.org/8738 (ec: Fix some size_t vars to 64 bits even on 32 bits machines) posted (#1) for review on master by Xavier Hernandez (xhernandez)

--- Additional comment from Anand Avati on 2014-09-19 09:54:38 CEST ---

REVIEW: http://review.gluster.org/8738 (ec: Fix some size_t vars to 64 bits even on 32 bits machines) posted (#2) for review on master by Xavier Hernandez (xhernandez)

--- Additional comment from Anand Avati on 2014-09-19 12:02:51 CEST ---

COMMIT: http://review.gluster.org/8738 committed in master by Vijay Bellur (vbellur) 
------
commit f32378b660dab5f3f311da8252969a7da16898f4
Author: Xavier Hernandez <xhernandez>
Date:   Mon Sep 15 11:57:43 2014 +0200

    ec: Fix some size_t vars to 64 bits even on 32 bits machines
    
    The 64 bits 'trusted.ec.size' extended attribute was incorrectly
    computed on 32 bits machines due to an overflow on negative
    numbers.
    
    Also changed some potentially dangerous uses of size_t in other
    places.
    
    Change-Id: Id76cfe49a2f350e564b5c71d8c8644fb9ce86662
    BUG: 1125312
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/8738
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 1 Anand Avati 2014-09-19 10:19:59 UTC

REVIEW: http://review.gluster.org/8779 (ec: Fix some size_t vars to 64 bits even on 32 bits machines) posted (#1) for review on release-3.6 by Xavier Hernandez (xhernandez)

Comment 2 Anand Avati 2014-09-19 19:35:08 UTC

COMMIT: http://review.gluster.org/8779 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit b98bfbc93b420ad47ad5008e738923bce683fc98
Author: Xavier Hernandez <xhernandez>
Date:   Mon Sep 15 11:57:43 2014 +0200

    ec: Fix some size_t vars to 64 bits even on 32 bits machines
    
    The 64 bits 'trusted.ec.size' extended attribute was incorrectly
    computed on 32 bits machines due to an overflow on negative
    numbers.
    
    Also changed some potentially dangerous uses of size_t in other
    places.
    
    This is a backport of http://review.gluster.org/8738/
    
    Change-Id: Id76cfe49a2f350e564b5c71d8c8644fb9ce86662
    BUG: 1144407
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/8779
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2014-09-22 12:46:36 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 4 Niels de Vos 2014-11-11 08:39:21 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users