Created attachment 942690[details]
engine log
Description of problem:
After live storage migration completes successfuly, the
"Auto-generated for Live Storage Migration" snapshot is left
in "Locked" state.
This prevents various actions with the vm or the disk.
Version-Release number of selected component (if applicable):
oVirt Engine Version: 3.5.0-0.0.master.20140911091402.gite1c5ffd.fc20
How reproducible:
Always
Steps to Reproduce:
1. Setup a dc with 2 iscsi storage domains
2. Create and start a vim with one disk on one of the domains
3. Move disk to the other domain
Actual results:
Migration succeeds, but the auto-generated snapshot is left in "Locked" state.
Expected results:
Migration succeeds, but the auto-generated snapshot is left in "OK" state.
Additional info:
While the migration is running, there are two tasks:
# vdsClient -s 0 getAllTasksInfo
0dc68bba-1b9b-4f5f-8811-ba9db222b633 :
verb = syncImageData
id = 0dc68bba-1b9b-4f5f-8811-ba9db222b633
186121fa-8604-462b-a8d3-c09adf830775 :
verb = createVolume
id = 186121fa-8604-462b-a8d3-c09adf830775
When the migration finish, we have only one task:
# vdsClient -s 0 getAllTasksInfo
186121fa-8604-462b-a8d3-c09adf830775 :
verb = createVolume
id = 186121fa-8604-462b-a8d3-c09adf830775
This task is finished, but not cleaned up by engine:
# vdsClient -s 0 getAllTasks
186121fa-8604-462b-a8d3-c09adf830775 :
verb = createVolume
code = 0
state = finished
tag = spm
result = {'uuid': 'f6d11460-fcd1-4b40-8e50-56a2ad6347a5'}
message = 1 jobs completed successfully
id = 186121fa-8604-462b-a8d3-c09adf830775
Workaround:
Unlock the snapshot using the unlock_entity.sh tool:
$ sudo /usr/share/ovirt-engine/dbscripts/unlock_entity.sh -t snapshot 98e6058d-cf96-4929-b118-4fc5542a30ba d3496bdc-76c4-4090-934e-e297fcba2cd8
Forgot to mention that using unlock_entity tool, we can see that snapshot is locked after migration finished:
$ sudo /usr/share/ovirt-engine/dbscripts/unlock_entity.sh -t snapshot -q
98e6058d-cf96-4929-b118-4fc5542a30ba | d3496bdc-76c4-4090-934e-e297fcba2cd8
Yair/Ravi,
It looks like the first task invoked by SEAT mechanism isn't getting cleaned (while the consequence tasks are being cleaned properly).
(it seems that a similar issue has been found on disk snapshots removal: bug 1134866).
Could it be related to recent CoCo infrastructure changes?
The source of this issue is a behavior change in CommandBase (as seen in the attached patch by Ravi).
Moving to infra to track this to completion. Of course, if there is a storage specific issue here, please return the whiteboard to storage.
Created attachment 942690 [details] engine log Description of problem: After live storage migration completes successfuly, the "Auto-generated for Live Storage Migration" snapshot is left in "Locked" state. This prevents various actions with the vm or the disk. Version-Release number of selected component (if applicable): oVirt Engine Version: 3.5.0-0.0.master.20140911091402.gite1c5ffd.fc20 How reproducible: Always Steps to Reproduce: 1. Setup a dc with 2 iscsi storage domains 2. Create and start a vim with one disk on one of the domains 3. Move disk to the other domain Actual results: Migration succeeds, but the auto-generated snapshot is left in "Locked" state. Expected results: Migration succeeds, but the auto-generated snapshot is left in "OK" state. Additional info: While the migration is running, there are two tasks: # vdsClient -s 0 getAllTasksInfo 0dc68bba-1b9b-4f5f-8811-ba9db222b633 : verb = syncImageData id = 0dc68bba-1b9b-4f5f-8811-ba9db222b633 186121fa-8604-462b-a8d3-c09adf830775 : verb = createVolume id = 186121fa-8604-462b-a8d3-c09adf830775 When the migration finish, we have only one task: # vdsClient -s 0 getAllTasksInfo 186121fa-8604-462b-a8d3-c09adf830775 : verb = createVolume id = 186121fa-8604-462b-a8d3-c09adf830775 This task is finished, but not cleaned up by engine: # vdsClient -s 0 getAllTasks 186121fa-8604-462b-a8d3-c09adf830775 : verb = createVolume code = 0 state = finished tag = spm result = {'uuid': 'f6d11460-fcd1-4b40-8e50-56a2ad6347a5'} message = 1 jobs completed successfully id = 186121fa-8604-462b-a8d3-c09adf830775 Workaround: Unlock the snapshot using the unlock_entity.sh tool: $ sudo /usr/share/ovirt-engine/dbscripts/unlock_entity.sh -t snapshot 98e6058d-cf96-4929-b118-4fc5542a30ba d3496bdc-76c4-4090-934e-e297fcba2cd8