Bug 1151827

Summary:	VM cpu hot plug succeed, though it exceeds Quota cpu limit
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Ilanit Stein <istein>
Component:	ovirt-engine	Assignee:	Omer Frenkel <ofrenkel>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ilanit Stein <istein>
Severity:	high	Docs Contact:
Priority:	high
Version:	3.5.0	CC:	dfediuck, ecohen, eedri, gklein, iheim, lpeer, lsurette, mavital, michal.skrivanek, ofrenkel, rbalakri, Rhev-m-bugs, sbonazzo, scohen, yeylon
Target Milestone:	---	Keywords:	Regression
Target Release:	3.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	virt
Fixed In Version:	org.ovirt.engine-root-3.5.0-15	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-02-17 08:26:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1073943, 1147536, 1164308, 1164311

Description Ilanit Stein 2014-10-12 12:12:25 UTC

Description of problem:
When setting quota to 1 cpu limit. VM with 1 cpu - cpu hot plug to or to 3, succeed!, though it should have failed, on quota cpu limit. 

Version-Release number of selected component (if applicable):
vt5

How reproducible:
100%

Additional info:
There was same bug, for 3.4, that was verified: 
https://bugzilla.redhat.com/https://bugzilla.redhat.com/1083177

Expected results:
User is violating the quota, the action should not be permitted.

Comment 2 Gilad Chaplik 2014-10-13 10:29:26 UTC

hotSetCpu command numOfSockets parameter is passed with no change.

Moving to virt.

Comment 3 Sandro Bonazzola 2014-10-14 12:59:25 UTC

Shouldn't this be in modified since all patches have been merged?

Comment 4 Omer Frenkel 2014-10-14 13:03:27 UTC

yes it was merged just now

Comment 5 Ilanit Stein 2014-10-19 11:59:44 UTC

Verified on vt6.
Now cpu host plug is working OK. Following UI cpu socket hot plug, A rhel6.5 guest 'lscpu' show indeed the number of cpus is updated.

Comment 6 Ilanit Stein 2014-10-19 13:05:44 UTC

Correction: This bug is NOT verified on vt6:

The cpu hot-plug is working on vt6, only in the situation where there is NO quota defined in the data center.
If adding a quota, of 1 vCPU, this bug still exist in vt6.

Comment 7 Ilanit Stein 2014-10-19 13:18:43 UTC

Eyal,

Would you please check if this fix is indeed included in vt6?

Thank you,
Ilanit.

Comment 8 Eyal Edri 2014-10-19 13:28:21 UTC

it's in:
https://gerrit.eng.lab.tlv.redhat.com/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-3.5.0_vt6

http://gerrit.ovirt.org/#/c/34084/

Comment 9 Ilanit Stein 2014-10-19 13:38:01 UTC

My mistake, moving to verified.

When there is no quota cpu hot plug work ok (guest updated).
When there is a quota (num of cpu limit) the cpu host plug work, and blocked, when quota is exceeded.

Comment 10 Omer Frenkel 2015-02-17 08:26:11 UTC

RHEV-M 3.5.0 has been released