Bug 1159826 (lxqt-globalkeys)
| Summary: | Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Helio Chissini de Castro <hcastro> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jmunilla, kevin, mtasaka, package-review, rdieter, ti.eugene |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-20 17:58:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1157402, 1159841 | ||
|
Description
Helio Chissini de Castro
2014-11-03 12:52:56 UTC
naming: ok license: ok, but could be ammended to Licence: LGPLv2+ sources: ok 884e0a66f978e58fd13401bcacab1dd7 lxqt-globalkeys-0.8.0.tar.xz macros: ok scriptlets: n/a, ok clean, simple again, APPROVED. * https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#desktop-file-install_usage * https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Shared_Libraries * https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_and_Directory_Ownership * Does not build http://koji.fedoraproject.org/koji/taskinfo?taskID=8068598 The build failures and directory ownership are liblxqt issues (should be fixed now), not here I was blind to this package needing scriptlets though, need to add: * .desktop file validation * ldconfig scriptlets ^^ consider those both MUST blockers items (revoking approval), please resubmit updated .spec/srpm Fixed in https://heliocastro.fedorapeople.org/lxqt/lxqt-globalkeys-0.8.0-4.fc21.src.rpm https://heliocastro.fedorapeople.org/lxqt/lxqt-globalkeys.spec looks good, APPROVED. 2 small non-blocking nits: * I'll have to verify if running desktop-file-edit effectively validates .desktop files or not, else we ought to add an explicit -validate step afterward. * License: tag still says LGPLv2 Confirmed, it validates as well. No need to run a second desktop-file-validte License will be changed as enter in the SCM New Package SCM Request ======================= Package Name: lxqt-globalkeys Short Description: Global keys utility for LXQt desktop suite Upstream URL: http://lxqt.org/downloads/lxqt/0.8.0/lxqt-globalkeys-0.8.0.tar.xz Owners: heliocastro rdieter tieugene Branches: f20 f21 el6 epel7 InitialCC: heliocastro New Package SCM Request ======================= Package Name: lxqt-globalkeys Short Description: Global keys utility for LXQt desktop suite Upstream URL: http://lxqt.org/ Owners: heliocastro rdieter tieugene Branches: f20 f21 el6 epel7 InitialCC: heliocastro Git done (by process-git-requests). imported |