Bug 1159841 (lxqt-runner) - Review Request: lxqt-runner - Application runner agent for LXQt desktop suite
Summary: Review Request: lxqt-runner - Application runner agent for LXQt desktop suite
Keywords:
Status: CLOSED RAWHIDE
Alias: lxqt-runner
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1157402 lxqt-globalkeys
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-03 13:37 UTC by Helio Chissini de Castro
Modified: 2015-11-12 01:44 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-20 13:12:04 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Helio Chissini de Castro 2014-11-03 13:37:20 UTC
Spec URL: https://heliocastro.fedorapeople.org/lxqt/lxqt-runner.spec
SRPM URL: https://heliocastro.fedorapeople.org/lxqt/lxqt-runner-0.8.0-2.fc21.src.rpm
Description: Application runner agent for LXQt desktop suite
Fedora Account System Username: heliocastro

Comment 1 Rex Dieter 2014-11-07 18:08:27 UTC
naming: ok

sources: ok
95d8fb3041987f89cb5d570eebfb99c9  lxqt-runner-0.8.0.tar.xz

licence: ok, but could be ammended to:
Licence: LGPLv2+

macros: ok

scriptlets: n/a, ok


APPROVED

Comment 2 Mamoru TASAKA 2014-11-08 05:02:38 UTC
* So what owns
  - %{_datadir}/lxqt-qt5/
  - %{_datadir}/lxqt/
?

Comment 3 Rex Dieter 2014-11-08 13:07:37 UTC
liblxqt now owns /usr/share/lxqt-qt5 , can add /usr/share/lxqt there too I suppose.

Helio, shouldn't all packages be using /usr/share/lxqt-qt5 ie, if not, it's a bug)?

Comment 4 Helio Chissini de Castro 2014-11-10 10:48:28 UTC
Yes, it's a bug.
I'm updating the spec file and patching code if necessary.

Comment 6 Rex Dieter 2014-11-10 12:51:19 UTC
Looks good, thanks, APPROVED

Comment 7 Helio Chissini de Castro 2014-11-12 15:12:20 UTC
New Package SCM Request
=======================
Package Name: lxqt-runner
Short Description: Application runner agent for LXQt desktop suite
Upstream URL: http://lxqt.org
Owners: heliocastro rdieter tieugene
Branches: f20 f21 el6 epel7
InitialCC: heliocastro

Comment 8 Gwyn Ciesla 2014-11-13 19:42:18 UTC
Git done (by process-git-requests).

Comment 9 Rex Dieter 2014-11-20 13:12:04 UTC
imported


Note You need to log in before you can comment on or make changes to this bug.