Spec URL: https://heliocastro.fedorapeople.org/lxqt/lxqt-globalkeys.spec SRPM URL: https://heliocastro.fedorapeople.org/lxqt/lxqt-globalkeys-0.8.0-3.fc21.src.rpm Description: Global keys utility for LXQt desktop suite Fedora Account System Username: heliocastro
naming: ok license: ok, but could be ammended to Licence: LGPLv2+ sources: ok 884e0a66f978e58fd13401bcacab1dd7 lxqt-globalkeys-0.8.0.tar.xz macros: ok scriptlets: n/a, ok clean, simple again, APPROVED.
* https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#desktop-file-install_usage * https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Shared_Libraries * https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_and_Directory_Ownership
* Does not build http://koji.fedoraproject.org/koji/taskinfo?taskID=8068598
The build failures and directory ownership are liblxqt issues (should be fixed now), not here I was blind to this package needing scriptlets though, need to add: * .desktop file validation * ldconfig scriptlets ^^ consider those both MUST blockers items (revoking approval), please resubmit updated .spec/srpm
Fixed in https://heliocastro.fedorapeople.org/lxqt/lxqt-globalkeys-0.8.0-4.fc21.src.rpm https://heliocastro.fedorapeople.org/lxqt/lxqt-globalkeys.spec
looks good, APPROVED. 2 small non-blocking nits: * I'll have to verify if running desktop-file-edit effectively validates .desktop files or not, else we ought to add an explicit -validate step afterward. * License: tag still says LGPLv2
Confirmed, it validates as well. No need to run a second desktop-file-validte License will be changed as enter in the SCM
New Package SCM Request ======================= Package Name: lxqt-globalkeys Short Description: Global keys utility for LXQt desktop suite Upstream URL: http://lxqt.org/downloads/lxqt/0.8.0/lxqt-globalkeys-0.8.0.tar.xz Owners: heliocastro rdieter tieugene Branches: f20 f21 el6 epel7 InitialCC: heliocastro
New Package SCM Request ======================= Package Name: lxqt-globalkeys Short Description: Global keys utility for LXQt desktop suite Upstream URL: http://lxqt.org/ Owners: heliocastro rdieter tieugene Branches: f20 f21 el6 epel7 InitialCC: heliocastro
Git done (by process-git-requests).
imported