Bug 1159841 (lxqt-runner)

Summary:	Review Request: lxqt-runner - Application runner agent for LXQt desktop suite
Product:	[Fedora] Fedora	Reporter:	Helio Chissini de Castro <hcastro>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hcastro, jmunilla, mtasaka, package-review, rdieter, ti.eugene
Target Milestone:	---	Flags:	rdieter: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-20 13:12:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1157402, 1159826
Bug Blocks:

Description Helio Chissini de Castro 2014-11-03 13:37:20 UTC

Spec URL: https://heliocastro.fedorapeople.org/lxqt/lxqt-runner.spec
SRPM URL: https://heliocastro.fedorapeople.org/lxqt/lxqt-runner-0.8.0-2.fc21.src.rpm
Description: Application runner agent for LXQt desktop suite
Fedora Account System Username: heliocastro

Comment 1 Rex Dieter 2014-11-07 18:08:27 UTC

naming: ok

sources: ok
95d8fb3041987f89cb5d570eebfb99c9  lxqt-runner-0.8.0.tar.xz

licence: ok, but could be ammended to:
Licence: LGPLv2+

macros: ok

scriptlets: n/a, ok


APPROVED

Comment 2 Mamoru TASAKA 2014-11-08 05:02:38 UTC

* So what owns
  - %{_datadir}/lxqt-qt5/
  - %{_datadir}/lxqt/
?

Comment 3 Rex Dieter 2014-11-08 13:07:37 UTC

liblxqt now owns /usr/share/lxqt-qt5 , can add /usr/share/lxqt there too I suppose.

Helio, shouldn't all packages be using /usr/share/lxqt-qt5 ie, if not, it's a bug)?

Comment 4 Helio Chissini de Castro 2014-11-10 10:48:28 UTC

Yes, it's a bug.
I'm updating the spec file and patching code if necessary.

Comment 5 Helio Chissini de Castro 2014-11-10 11:23:01 UTC

Updated on 
https://heliocastro.fedorapeople.org/lxqt/lxqt-runner-0.8.0-3.fc21.src.rpm
https://heliocastro.fedorapeople.org/lxqt/lxqt-runner.spec

Comment 6 Rex Dieter 2014-11-10 12:51:19 UTC

Looks good, thanks, APPROVED

Comment 7 Helio Chissini de Castro 2014-11-12 15:12:20 UTC

New Package SCM Request
=======================
Package Name: lxqt-runner
Short Description: Application runner agent for LXQt desktop suite
Upstream URL: http://lxqt.org
Owners: heliocastro rdieter tieugene
Branches: f20 f21 el6 epel7
InitialCC: heliocastro

Comment 8 Gwyn Ciesla 2014-11-13 19:42:18 UTC

Git done (by process-git-requests).

Comment 9 Rex Dieter 2014-11-20 13:12:04 UTC

imported