Bug 1160094

Summary: [RFE] Edit the settings of the hosted engine VM in the GUI
Product: [oVirt] ovirt-engine Reporter: Andrew Burden <aburden>
Component: RFEsAssignee: Roy Golan <rgolan>
Status: CLOSED CURRENTRELEASE QA Contact: Artyom <alukiano>
Severity: medium Docs Contact:
Priority: high    
Version: ---CC: bugs, dfediuck, gklein, iheim, lpeer, lsurette, mavital, mgoldboi, mkalinin, rbalakri, rgolan, Rhev-m-bugs, sbonazzo, srevivo, ykaul
Target Milestone: ovirt-3.6.5Keywords: FutureFeature, Triaged
Target Release: 3.6.5Flags: rule-engine: ovirt-3.6.z+
sherold: Triaged+
ylavi: planning_ack+
dfediuck: devel_ack+
mavital: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.ovirt.org/Hosted_engine_VM_management
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Feature: Switching from per-host editing of the hosted engine vm to the regular engine flow of updating a vm via REST api or UI. Reason: Instead of cumbersome, error-prone, local editing the vm.conf on each and every HA host we use the engine itself to edit it. The change should be made in one place, once. Result: A change via ovirt-engine is kept in the engine DB and propagated into the OVF_STORE disk on the storage donmain. So it is both shared, and backed-up and highly available.
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-21 14:39:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1290478, 1304323, 1311908, 1321796    
Bug Blocks: 1139492    

Description Andrew Burden 2014-11-04 02:41:40 UTC
Description of problem:
Request ability to edit the settings of the hosted engine VM in the GUI, following BZ#1138495. At present the workaround is to edit the vm.conf and manually copy the file to all hosts, updating the db to see changes in the GUI. Support requested this workaround not be published but that this functionality be built into the GUI.

Comment 1 Itamar Heim 2014-11-21 02:47:20 UTC
if we move to store the vm definition as a normal ovf on the storage domain as part of moving the vm definition to shared storage, then editing it via the engine will update that ovf for next reboot?

Comment 2 Doron Fediuck 2014-11-23 11:16:15 UTC
(In reply to Itamar Heim from comment #1)
> if we move to store the vm definition as a normal ovf on the storage domain
> as part of moving the vm definition to shared storage, then editing it via
> the engine will update that ovf for next reboot?

We need to review it, since it means we need to update the OVF on every
change and 're-import' it on every boot. Then we may want to consider
'last good configuration' in case something goes wrong. And there are
other considerations such as having the storage path available in each
host to be able to run the VM in the first place or when it goes down.

Comment 3 Itamar Heim 2014-11-23 22:44:57 UTC
the ovf only contains vm config, not storage connection info.
the ovf gets updated every x minutes automatically in any case.

Comment 4 Red Hat Bugzilla Rules Engine 2015-12-23 11:28:49 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 6 Red Hat Bugzilla Rules Engine 2016-02-22 13:03:45 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 7 Eyal Edri 2016-03-31 08:35:56 UTC
Bugs moved pre-mature to ON_QA since they didn't have target release.
Notice that only bugs with a set target release will move to ON_QA.

Comment 8 Artyom 2016-04-04 15:54:19 UTC
Checked on rhevm-3.6.5.1-0.1.el6.noarch
When I try to edit HE VM I receive error message:
Cannot edit VM. The VM is a hosted engine and editing is not allowed. See configuration value AllowEditingHostedEngine.

Comment 9 Red Hat Bugzilla Rules Engine 2016-04-04 15:54:28 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 10 Artyom 2016-04-14 14:12:34 UTC
Verified on rhevm-3.6.5.3-0.1.el6.noarch

1) Change HE VM memory - PASS (need to restart HE VM to apply changes, also appear audit error message, connect to hotplug)
2) Change HE VM CPU - PASS (need to restart HE VM to apply changes, also appear audit error message, connect to hotplug)
3) Add and remove new VNIC to HE VM (you need to create different from management network to add new VNIC above it)

Comment 11 Marina Kalinin 2016-05-18 21:22:20 UTC
Should we retire this kcs?
Or specify, starting 3.6.5 do it the regular way on the Admin Portal?

https://access.redhat.com/solutions/2209751

Comment 12 Marina Kalinin 2016-05-18 21:41:04 UTC
Now I am confused, I just successfully modified my HE VM, however:

# engine-config -g AllowEditingHostedEngine
AllowEditingHostedEngine: false version: general


So, why do we need this flag?
P.S. it is an upgraded environment from 3.6.3.

Comment 13 Roy Golan 2016-05-19 07:12:56 UTC
(In reply to Marina from comment #12)
> Now I am confused, I just successfully modified my HE VM, however:
> 
> # engine-config -g AllowEditingHostedEngine
> AllowEditingHostedEngine: false version: general
> 
> 
> So, why do we need this flag?
> P.S. it is an upgraded environment from 3.6.3.

What exactly did you change and how?

Comment 14 Marina Kalinin 2016-05-19 16:40:01 UTC
I added a vnic to HE VM through the admin portal.

I could not do it on 3.6.3. I upgraded to 3.6.5, and then it worked, I could add the vnic. Then I checked the config value and it was false.

Comment 15 Marina Kalinin 2016-05-27 14:39:34 UTC
I am wondering, maybe my bug#1337711  is because I didn't have AllowEditingHostedEngine set to true? I will try that now.

Comment 16 Marina Kalinin 2016-05-28 02:07:10 UTC
Nope, does not matter the value of this config. The problem is still there. So I am not sure what is the point of this config.