Bug 1311908 - Edit VM dialog save action calls UpdateVmDiskCommand even though no disk change happened
Summary: Edit VM dialog save action calls UpdateVmDiskCommand even though no disk chan...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-3.6.5
: 3.6.5
Assignee: Marek Libra
QA Contact: Artyom
URL:
Whiteboard:
: 1304323 (view as bug list)
Depends On:
Blocks: 1160094
TreeView+ depends on / blocked
 
Reported: 2016-02-25 10:02 UTC by Martin Sivák
Modified: 2016-04-21 14:35 UTC (History)
6 users (show)

Fixed In Version: 3.6.5-1
Clone Of:
Environment:
Last Closed: 2016-04-21 14:35:34 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-3.6.z+
mgoldboi: planning_ack+
michal.skrivanek: devel_ack+
mavital: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 54755 0 master MERGED webadmin: Avoid UpdateVmDiskCommand for hosted engine Edit VM 2016-03-23 08:16:18 UTC
oVirt gerrit 55125 0 ovirt-engine-3.6 MERGED engine: Added VmActionByVmOriginTypeValidator for Allowed Cmds 2016-03-25 07:25:53 UTC
oVirt gerrit 55126 0 ovirt-engine-3.6 MERGED webadmin: Avoid UpdateVmDiskCommand for hosted engine Edit VM 2016-03-25 07:29:33 UTC

Description Martin Sivák 2016-02-25 10:02:57 UTC
Description of problem:

Usability and UX issue. This does not break any functionality.

When the Edit VM dialog is dismissed using the OK button two backend commands are called:

UpdateVmCommand and UpdateVmDiskCommand

We only allow editing some fields for the hosted engine VM and check for it in the UpdateVmCommand. But the user always gets an error from the UpdateVmDisk command because it specifically disallows changes to hosted engine VM's disks.

This would be fine if the user actually attempted to change something in the disk area. But the error is displayed even when no disk change is requested.

Version-Release number of selected component (if applicable):

master branch, but probably 3.6 too

How reproducible:

Always

Steps to Reproduce:
1. Use hosted engine VM or change the origin type of some arbitrary VM to 6 (MANAGED_HOSTED_ENGINE)
2. Edit VM (pre 3.6.3, or ask for my patches)
3. Observe the error

Actual results:

Disk update command is always called and always shows the error message.

Expected results:

Disk update should only be executed when a change is detected.

Comment 1 Martin Sivák 2016-03-02 10:31:59 UTC
*** Bug 1304323 has been marked as a duplicate of this bug. ***

Comment 2 Artyom 2016-04-13 12:55:37 UTC
Verified on rhevm-3.6.5.3-0.1.el6.noarch


Note You need to log in before you can comment on or make changes to this bug.