Bug 1166598
Summary: | going back to installation destination picker swaps partitions on disks | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Marian Csontos <mcsontos> | ||||
Component: | anaconda | Assignee: | Vratislav Podzimek <vpodzime> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 22 | CC: | aj.werkman, anaconda-maint-list, awilliam, extras-qa, g.kaviyarasu, iamakritiverma654321, jfrieben, jonathan, jreznik, jsedlak, kparal, lbrabec, mcsontos, mohittokas, mruckman, pschindl, robatino, satellitgo, tadej.j, vanmeeuwen+fedora, vpodzime | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | x86_64 | ||||||
OS: | Unspecified | ||||||
Whiteboard: | abrt_hash:402fec84f3c73861261419db5c1da8f02316c9a64549b091bc9ca08eca246b37 https://fedoraproject.org/wiki/Common_F21_bugs#anaconda-part-multi AcceptedBlocker | ||||||
Fixed In Version: | anaconda-22.20.11-1.fc22 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | 1158533 | Environment: | |||||
Last Closed: | 2015-05-03 17:23:36 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 1043130 | ||||||
Attachments: |
|
Description
Marian Csontos
2014-11-21 10:26:57 UTC
"Cloning" relevant attachments: (In reply to Petr Schindler from comment #16) > Created attachment 952037 [details] > reclaim space dialog when opened for the first time (In reply to Petr Schindler from comment #17) > Created attachment 952039 [details] > reclaim space dialog when opened for the second time with just first disk (In reply to Petr Schindler from comment #21) > Created attachment 952142 [details] > anaconda.log (In reply to Petr Schindler from comment #22) > Created attachment 952143 [details] > traceback (In reply to Petr Schindler from comment #23) > Created attachment 952146 [details] > program.log (In reply to Petr Schindler from comment #24) > Created attachment 952147 [details] > storage.log And the other reporter's files: (In reply to Jan Sedlák from bug 1158533, comment 35) > Created attachment 959379 [details] > anaconda traceback (In reply to Jan Sedlák from bug 1158533, comment 36) > Created attachment 959380 [details] > storage.log It reverts disks too - it is visible in the Bug 1158911: attachment 952119 [details] File: lsblk_output attachment 952122 [details] File: program.log attachment 952123 [details] File: storage.log There is no /dev/sda2 in lsblk_output but there are two partitions on /dev/vda. *** Bug 1158911 has been marked as a duplicate of this bug. *** I managed to identify the core of the problem and I'm now working on a patch for pyparted and blivet to fix this issue. The patches should be ready in an hour or two. Vratislav, if you can produce an updates.img for TC4, we can test it right away. Thanks. (In reply to Kamil Páral from comment #6) > Vratislav, if you can produce an updates.img for TC4, we can test it right > away. Thanks. http://vpodzime.fedorapeople.org/1166598_updates.img (hopefully I didn't leave any debugging lines in it) anaconda-21.48.17-1.fc21, python-blivet-0.61.11-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-blivet-0.61.11-1.fc21,anaconda-21.48.17-1.fc21 Ok, tried updates.img from comment 5 and it works now. Disks have correct labels in reclaim space dialog and installation completes without error. I tried with https://vpodzime.fedorapeople.org/ultimate_f21_updates.img and the problem is fixed. I used this reproducer: > Had one disk with two partitions - /boot (vda1) and / (vda2). Went to > partitioning spoke, selected that disk for installation, clicked done, clicked > "delete all" on reclaim space dialog. Then went to partitioning spoke again, > unselected that disk and clicked "done". Finally, went to partitioning spoke > again, selected that disk again and clicked "done". In reclaim space dialog, > both partitions had swapped names (/boot was vda2 and / was vda1). When I > started installation, the exception showed up. There's still one small glitch, though. After you open the storage screen for the third time (after you unselected the disk and want to select it again), its label says its completely free ("10 GiB free") even though it's completely full. Package anaconda-21.48.17-1.fc21, python-blivet-0.61.11-1.fc21, pyparted-3.10.2-1.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-21.48.17-1.fc21 python-blivet-0.61.11-1.fc21 pyparted-3.10.2-1.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-15910/pyparted-3.10.2-1.fc21,python-blivet-0.61.11-1.fc21,anaconda-21.48.17-1.fc21 then log in and leave karma (feedback). Package pyparted-3.10.2-1.fc21, python-blivet-0.61.12-1.fc21, anaconda-21.48.18-1.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing pyparted-3.10.2-1.fc21 python-blivet-0.61.12-1.fc21 anaconda-21.48.18-1.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-15910/pyparted-3.10.2-1.fc21,python-blivet-0.61.12-1.fc21,anaconda-21.48.18-1.fc21 then log in and leave karma (feedback). This works well in RC1. Just a note (because we're discussing it right now), this bug in new in F21 and hasn't been present in F20. We might need this information during today's blocker bug meeting. (In reply to Kamil Páral from comment #14) > Just a note (because we're discussing it right now), this bug in new in F21 > and hasn't been present in F20. We might need this information during > today's blocker bug meeting. Correction, I can't hit this with the single disk use case in F20, but it can be hit using multiple disks use case in F20. For the record, I can't reproduce this as described with the c#10 reproducer. Following those steps I see the partitions the wrong way round in the reclaim space dialog - sda2 is the first entry on the list, sda1 is the second - but all the information matches up: sda1's mount point is /boot and its size is 500MB, sda2's mount point is / and its size is XXGiB. Discussed in 2014-12-03 blocker review meeting. We're reverting this bugs blocker status: The provided fix for this bug caused a larger issue. At this point in the release it's better to revert and document the problem clearly. Repropose this as a F22 Alpha blocker to get a fix early in the next release. Created attachment 964267 [details]
bug demonstration video
To illustrate the problem, this is reproduced with TC4.
OK, we figured out the difference in cases. Refined reproducer: 1. Start with a single existing disk with a 500MB ext4 /boot partition as its first partition (Xda1) and the rest of the disk occupied by an LVM VG (Xda2) - an easy way to do this is to do a stock Fedora installation. 2. Boot Fedora 21 Final TC4 installer. 3. Go to Installation Destination, leave the disk selected as the install target, click Done. 4. On the Installation Options popup, click 'Reclaim space'. 5. On the RECLAIM DISK SPACE screen, click 'Delete all', click 'Reclaim space'. 6. Go to Installation Destination (second time), click the disk to unselect it, and click Done. 7. Go to Installation Destination (third time), leave the disk selected, and click Done. 8. On the Installation Options popup, click 'Reclaim space'. The bug should now be reproduced on the RECLAIM DISK SPACE screen: the 500MB /boot partition will be listed as 'Xda2' and the LVM VG as 'Xda1'. Setting back to ASSIGNED as the fix for this is being reverted. Confirmed that this bug is present in RC5. kparal: you can test with https://dlehman.fedorapeople.org/updates/updates-1166598.1.img I guess - dlehman posted it for me today. It seems to resolve the bug, for me. It's against TC4, though. (In reply to Adam Williamson (Red Hat) from comment #21) > kparal: you can test with > https://dlehman.fedorapeople.org/updates/updates-1166598.1.img I guess - > dlehman posted it for me today. It seems to resolve the bug, for me. It's > against TC4, though. It still swaps the lines (vda2 shows before vda1), but it does not mix them up (vda2 is still vda2, not in fact vda1). So in the use case from comment 19 it's an improvement. Tested with TC4. Discussed at today's blocker review meeting [1]. Agreed to delay decision on this. It's not clear where this bug or the fix currently stands. Punting until we have more information. [1] http://meetbot.fedoraproject.org/fedora-blocker-review/2015-01-07/ Discussed at 2015-01-12 blocker review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2015-01-12/f22-blocker-review.2015-01-12-16.06.log.txt . Accepted as a Beta blocker as a conditional violation of criterion https://fedoraproject.org/wiki/Fedora_22_Beta_Release_Criteria#Guided_partitioning - "When using the guided partitioning flow, the installer must be able to: ... Complete an installation using any combination of disk configuration options it allows the user to select" - in the case described. Another user experienced a similar problem: I was installing fedora on my system, set fedora to reclaim all the space on a disk and clicked next. Then this error appeared when i click on set root password on the next screen. cmdline: /usr/bin/python /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base cmdline_file: BOOT_IMAGE=vmlinuz0 initrd=initrd0.img root=live:CDLABEL=Fedora-Live-WS-x86_64-21-5 rootfstype=auto ro rd.live.image quiet rhgb rd.luks=0 rd.md=0 rd.dm=0 hashmarkername: anaconda kernel: 3.17.4-301.fc21.x86_64 other involved packages: python-blivet-0.61.13-1.fc21.noarch, python-libs-2.7.8-7.fc21.x86_64 package: anaconda-core-21.48.21-1.fc21.x86_64 packaging.log: product: Fedora" reason: FormatDestroyError: error wiping old signatures from /dev/sdb2: 1 release: Fedora release 21 (Twenty One) version: Fedora Another user experienced a similar problem: I was setting partitioning and used the option to "Delete all" existing partitions and after clicking Next, Anaconda crashed. cmdline: /usr/bin/python /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base cmdline_file: BOOT_IMAGE=vmlinuz0 initrd=initrd0.img root=live:CDLABEL=Fedora-Live-WS-x86_64-21-5 rootfstype=auto ro rd.live.image quiet rhgb rd.luks=0 rd.md=0 rd.dm=0 hashmarkername: anaconda kernel: 3.17.4-301.fc21.x86_64 other involved packages: python-blivet-0.61.13-1.fc21.noarch, python-libs-2.7.8-7.fc21.x86_64 package: anaconda-core-21.48.21-1.fc21.x86_64 packaging.log: product: Fedora" reason: FormatDestroyError: error wiping old signatures from /dev/sda1: 1 release: Fedora release 21 (Twenty One) version: Fedora Another user experienced a similar problem: Incident causé lors de l'installation de Fedora sur le disque dur. cmdline: /usr/bin/python /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base cmdline_file: BOOT_IMAGE=vmlinuz0 initrd=initrd0.img root=live:CDLABEL=Fedora-Live-WS-x86_64-21-5 rootfstype=auto ro rd.live.image quiet rhgb rd.luks=0 rd.md=0 rd.dm=0 hashmarkername: anaconda kernel: 3.17.4-301.fc21.x86_64 other involved packages: python-blivet-0.61.13-1.fc21.noarch, python-libs-2.7.8-7.fc21.x86_64 package: anaconda-core-21.48.21-1.fc21.x86_64 packaging.log: product: Fedora" reason: FormatDestroyError: error wiping old signatures from /dev/sdb2: 1 release: Fedora release 21 (Twenty One) version: Fedora Has someone checked the current status of this with 22? Not sure if this is the same, but I tried to reproduce this and ended with new bug 1201207 *** Bug 1201207 has been marked as a duplicate of this bug. *** Bumping to F22 I just tried it and it's still there. It's the same as in 21. (Tested with Beta TC1) So.... I discussed this issue with other members of the team and we agreed on the fact that the nice solution of really fixing action cancelling and override partitions numbers from blivet would very likely cause some more severe issues just like all the previous attempts did. Thus we would like to do a bit uglier, but still not completely bad change that should make this work as expected. However, it's not clear that we will make it in time to fix it for Beta. It would be great if this could be moved to Final as a blocker instead of beta. As Beta is getting closer, I'm ok with moving this to final if it will be fixed early in the final release phase. And have it as freeze exception in case we would slip Beta and it will be ready for inclusion. I forgot to drop the AcceptedBlocker from this so it would come up for review at the meeting this morning - sorry. I'm OK with punting at least to Final for this, it's sufficiently uncommon to be OK with just documentation for Beta. Any other votes? +1 for moving to Final +1 for Final too. That's five votes for moving to Final, let's do it. updates.img containing the potential fix: http://vpodzime.fedorapeople.org/1166598_updates.img (for anaconda-22.20.9-1 [Beta RC3]) (In reply to Vratislav Podzimek from comment #40) > updates.img containing the potential fix: > http://vpodzime.fedorapeople.org/1166598_updates.img (for anaconda-22.20.9-1 > [Beta RC3]) this fixed the bug for me anaconda-22.20.11-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/anaconda-22.20.11-1.fc22 Package anaconda-22.20.11-1.fc22, libblockdev-0.12-1.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-22.20.11-1.fc22 libblockdev-0.12-1.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-7011/libblockdev-0.12-1.fc22,anaconda-22.20.11-1.fc22 then log in and leave karma (feedback). anaconda-22.20.11-1.fc22, libblockdev-0.12-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. Verified fixed in F22 RC3. Amazing staff by the admin where we can have to learn great thing out from this topic. I hope you keep posting these types of great blogs. https://www.yaina.in/ |