Bug 1169926

Summary:	Review Request: zram - Enable compressed swap in memory
Product:	[Fedora] Fedora	Reporter:	Pavel Alexeev <pahan>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jorti, package-review, projects.rg, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-04 19:25:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pavel Alexeev 2014-12-02 18:16:56 UTC

Spec URL: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/c20c3b4e12b3c5cb81508574e3f676c25e5f0b44/SPECS/zram.spec
SRPM URL: http://hubbitus.info/rpm/Fedora21/zram/zram-1.0.0-1.git.5602a90.fc22.src.rpm
Description: zram compresses swap partitions into RAM for performance
Fedora Account System Username: hubbitus

Comment 1 Pavel Alexeev 2016-09-06 20:16:55 UTC

Update to f66237001b6a413d1e80710526a00fe26214797b

Changes: https://github.com/Hubbitus/rpm-zram/commit/dbdc37ca17ca4aca39c55c1a006271123b87022a
Spec: https://raw.githubusercontent.com/Hubbitus/rpm-zram/dbdc37ca17ca4aca39c55c1a006271123b87022a/zram.spec
Srpm: http://rpm.hubbitus.info/Fedora24/zram/zram-1.0.0-3.git.f662370.fc24.src.rpm

Comment 2 Juan Orti 2016-09-06 20:36:25 UTC

*** Bug 1179835 has been marked as a duplicate of this bug. ***

Comment 3 Pavel Alexeev 2016-10-26 19:29:38 UTC

Version 1.0.1

Changes: https://github.com/Hubbitus/rpm-zram/commit/779559575e5a60312e19bb81ac6982438d0d7c70
Spec: https://github.com/Hubbitus/rpm-zram/blob/779559575e5a60312e19bb81ac6982438d0d7c70/zram.spec
Srpm: http://rpm.hubbitus.info/epel7/zram/zram-1.0.1-1.git.f662370.el7.src.rpm

Comment 4 Raphael Groner 2017-07-11 18:04:56 UTC

IMHO it's better to build a package of Jiab77/systemd-zram instead, that project [1] has nearly the same code base and particularly a proper and valid licensing as MIT with full license text [2].
Although your spec file as well the upstream spec file say it's GPLv2, we can not verify the requirement [3] to ship the license text. You could point upstream to include license as headers [4] into their shell scripts.

[1] https://github.com/Jiab77/systemd-zram
[2] https://github.com/Jiab77/systemd-zram/blob/master/LICENSE
[3] https://www.gnu.org/licenses/gpl-faq.en.html#WhyMustIInclude
[4] https://www.gnu.org/licenses/gpl-faq.en.html#NoticeInSourceFile

Comment 5 Zbigniew Jędrzejewski-Szmek 2017-08-04 19:25:08 UTC

Let's continue in the newer review request. hubbitus seems to be MIA.

*** This bug has been marked as a duplicate of bug 1469726 ***

Comment 6 Pavel Alexeev 2017-08-13 15:27:25 UTC

What you meant under "hubbitus seems to be MIA"?

Comment 7 Zbigniew Jędrzejewski-Szmek 2017-08-13 17:22:46 UTC

It's good that you're back ;)
There was a thread on fedora-devel,
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/KHVYA7KZIAESHTHXOA3SDRX3KXAU5TJ7/#F4BVYP3YJRAEZUTXUGV6GG2QBVFMG2FG
and a fesco ticket:
https://meetbot.fedoraproject.org/fedora-meeting/2017-08-11/fesco.2017-08-11-16.01.html