Spec URL: https://jorti.fedorapeople.org/fedorazram/fedorazram.spec SRPM URL: https://jorti.fedorapeople.org/fedorazram/fedorazram-1.0.0-0.1.20150107git5602a90.fc21.src.rpm Description: zram compresses swap partitions into RAM for performance Fedora Account System Username: jorti
*** Bug 1168692 has been marked as a duplicate of this bug. ***
Spec URL: https://jorti.fedorapeople.org/fedorazram/fedorazram.spec SRPM URL: https://jorti.fedorapeople.org/fedorazram/fedorazram-1.0.0-2.20150525gitd41883a.fc22.src.rpm
I have significant doubts about the form that this is implemented. That kind of implementation would be fine for SysVInit, but for systemd, running such complicated shell scripts is something we try to avoid. Also using /etc/sysconfig, /bin/sleep, and unloading modules is frowned up. I don't think we should introduce this package into Fedora, and go into a leaner alternative from the start. I think this could be implemented as a systemd generator in a much cleaner way [1]. [1] http://www.freedesktop.org/software/systemd/man/systemd.generator.html
You are probably right, but it fills a niche that it's currently empty. I've made a copr with it, I hope it will be useful to someone: https://copr.fedoraproject.org/coprs/jorti/fedorazram/
I post on review it long time ago: https://bugzilla.redhat.com/show_bug.cgi?id=1169926
*** This bug has been marked as a duplicate of bug 1169926 ***
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3) … > I think this could be implemented as a systemd generator in a much cleaner > way [1]. > > [1] http://www.freedesktop.org/software/systemd/man/systemd.generator.html ICYMI Upstream did migrate since over at least two years ago: https://github.com/mystilleef/FedoraZram/commit/050d0a8267e0df119b7c8e4a10e9ed87600843f1