Bug 1170816
| Summary: | Review Request: nodejs-astral-angular-annotate - AngularJS DI annotation pass for astral | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Piotr Popieluch <piotr1212> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-astral-angular-annotate-0.0.2-2.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-14 12:33:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1170811, 1170815 | ||
| Bug Blocks: | |||
|
Description
Piotr Popieluch
2014-12-04 22:47:24 UTC
Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output nodejs-astral-angular-annotate.noarch: W: only-non-binary-in-usr-lib nodejs-astral-angular-annotate.noarch: W: dangling-symlink /usr/lib/node_modules/astral-angular-annotate/node_modules/astral-pass /usr/lib/node_modules/astral-pass nodejs-astral-angular-annotate.noarch: W: dangling-symlink /usr/lib/node_modules/astral-angular-annotate/node_modules/clone /usr/lib/node_modules/clone 2 packages and 0 specfiles checked; 0 errors, 3 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 9752eac4723557b1983f4b1f45539a3e08e62683c7e669c2ae0814bf57cbbc66 upstream tarball: 9752eac4723557b1983f4b1f45539a3e08e62683c7e669c2ae0814bf57cbbc66 + License is "MIT" - License text is not included. + follows nodejs packaging guidelines. Suggestions: 1) Group is optional, can be removed. 2) Ask upstream to add license text. License file requested: https://github.com/btford/astral-angular-annotate/issues/12 Fixed suggestions in: Spec URL: https://piotrp.fedorapeople.org/nodejs-astral-angular-annotate.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-astral-angular-annotate-0.0.2-2.fc21.src.rpm Looks like group tag still present, you can remove it at time of package import. Looks good now. Don't forget to keep asking upstream to include license text and when available update the package. APPROVED. New Package SCM Request ======================= Package Name: nodejs-astral-angular-annotate Short Description: AngularJS DI annotation pass for astral Upstream URL: Owners: piotrp Branches: f19 f20 f21 el6 epel7 InitialCC: https://github.com/btford/astral-angular-annotate New Package SCM Request ======================= Package Name: nodejs-astral-angular-annotate Short Description: AngularJS DI annotation pass for astral Upstream URL: https://github.com/btford/astral-angular-annotate Owners: piotrp Branches: f19 f20 f21 el6 epel7 InitialCC: Git done (by process-git-requests). nodejs-astral-angular-annotate-0.0.2-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-astral-angular-annotate-0.0.2-2.fc20 nodejs-astral-angular-annotate-0.0.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-astral-angular-annotate-0.0.2-2.fc19 nodejs-astral-angular-annotate-0.0.2-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-astral-angular-annotate-0.0.2-2.el7 nodejs-astral-angular-annotate-0.0.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository. Package built and in testing, closing bug. nodejs-astral-angular-annotate-0.0.2-2.fc20 has been pushed to the Fedora 20 stable repository. nodejs-astral-angular-annotate-0.0.2-2.fc19 has been pushed to the Fedora 19 stable repository. nodejs-astral-angular-annotate-0.0.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. |