Spec URL: https://piotrp.fedorapeople.org/nodejs-clone.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-clone-0.1.18-1.fc21.src.rpm Description: deep cloning of objects and arrays Fedora Account System Username: piotrp
Review: + Package built successful in mock (f22 x86_64) - rpmlint on generated rpms gave output nodejs-clone.noarch: W: summary-not-capitalized C deep cloning of objects and arrays nodejs-clone.noarch: W: only-non-binary-in-usr-lib nodejs-clone.src: W: summary-not-capitalized C deep cloning of objects and arrays 2 packages and 0 specfiles checked; 0 errors, 3 warnings. + Source verified with upstream as (sha256sum) srpm tarball: b55ad6319e733ae4d885f3ab2381249844768cf484054fa5c384d1941b8f7a74 upstream tarball: b55ad6319e733ae4d885f3ab2381249844768cf484054fa5c384d1941b8f7a74 + License is "MIT". - LICENSE file not included in %files + follows nodejs packaging guidelines. Suggestions: 1) Fix rpmlint warning summary-not-capitalized 2) Add LICENSE in %doc 3) you should in %prep rm -rf node_modules 4) Group tag is now optional so you can remove it.
thank you for review, suggestions fixed in: Spec URL: https://piotrp.fedorapeople.org/nodejs-clone.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-clone-0.1.18-2.fc21.src.rpm
Looks good. APPROVED.
New Package SCM Request ======================= Package Name: nodejs-clone Short Description: Deep cloning of objects and arrays Upstream URL: https://github.com/pvorb/node-clone Owners: piotrp Branches: f19 f20 f21 el6 epel7 InitialCC: piotrp
Git done (by process-git-requests).
nodejs-clone-0.1.18-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-clone-0.1.18-2.fc21
nodejs-clone-0.1.18-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-clone-0.1.18-2.fc20
nodejs-clone-0.1.18-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-clone-0.1.18-2.fc19
nodejs-clone-0.1.18-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-clone-0.1.18-2.el7
nodejs-clone-0.1.18-2.el7 has been pushed to the Fedora EPEL 7 testing repository.
Package built and in testing, closing bug.
nodejs-clone-0.1.18-2.fc19 has been pushed to the Fedora 19 stable repository.
nodejs-clone-0.1.18-2.fc21 has been pushed to the Fedora 21 stable repository.
nodejs-clone-0.1.18-2.fc20 has been pushed to the Fedora 20 stable repository.
nodejs-clone-0.1.18-2.el7 has been pushed to the Fedora EPEL 7 stable repository.