Bug 1172394

Summary:	[RFE] rename gwt-extension.jar->ovirt-engine-gwt-extension.jar
Product:	[oVirt] ovirt-engine	Reporter:	Einav Cohen <ecohen>
Component:	RFEs	Assignee:	Vojtech Szocs <vszocs>
Status:	CLOSED WONTFIX	QA Contact:	Jiri Belka <jbelka>
Severity:	low	Docs Contact:
Priority:	medium
Version:	---	CC:	bugs, gklein, iheim, jbelka, lsurette, mgoldboi, nbarcet, rbalakri, Rhev-m-bugs, sherold, vszocs, yeylon, ykaul
Target Milestone:	---	Keywords:	CodeChange, FutureFeature, Improvement
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:	1013752	Environment:
Last Closed:	2016-03-11 17:12:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	UX	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1013752
Bug Blocks:

Description Einav Cohen 2014-12-10 01:14:53 UTC

+++ This bug was initially created as a clone of Bug #1013752 +++

jar name without signature of ovirt can be mistakenly considered 3rd party.

if we can rename it it would be super!

Comment 1 Red Hat Bugzilla Rules Engine 2015-10-19 10:57:29 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 3 Yaniv Kaul 2016-03-10 15:07:36 UTC

Is it going to make it to 4.0?

Comment 4 Vojtech Szocs 2016-03-11 14:58:45 UTC

(In reply to Yaniv Kaul from comment #3)
> Is it going to make it to 4.0?

This BZ was cloned from BZ#1013752 and that one is now closed - I suggest to close this one too.

The issue is that someone might mistake "gwt-extension.jar" as 3rd party (GWT) dependency, but it's our code [a]. On the other hand, "gwt-servlet.jar" is indeed 3rd party (GWT) code, which sits right next to previously mentioned JAR file at [b].

[a] {ovirt_src}/frontend/webadmin/modules/gwt-extension
[b] /usr/share/ovirt-engine/engine.ear/{webadmin,userportal}.war/WEB-INF/lib

As suggested by Tomas in patch https://gerrit.ovirt.org/#/c/48551/ (now abandoned) a proper solution would be to have a consistent naming convention applied across all oVirt JAR files, so for now I'd suggest to close this and discuss/re-open if really needed.

Comment 5 Yaniv Kaul 2016-03-11 17:12:31 UTC

(In reply to vszocs from comment #4)
> (In reply to Yaniv Kaul from comment #3)
> > Is it going to make it to 4.0?
> 
> This BZ was cloned from BZ#1013752 and that one is now closed - I suggest to
> close this one too.

Agreed, thanks.